Skip to content

Commit 8a8206e

Browse files
committed
Update Reactive Java/Android to version 3
1 parent ef0db3f commit 8a8206e

File tree

5 files changed

+23
-20
lines changed

5 files changed

+23
-20
lines changed

buildsystem/dependencies.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ ext {
5757
// app frameworks and utilities
5858

5959
// todo updaten
60-
rxJavaVersion = '2.2.21'
61-
rxAndroidVersion = '2.1.1'
62-
rxBindingVersion = '2.2.0'
60+
rxJavaVersion = '3.1.11'
61+
rxAndroidVersion = '3.0.2'
62+
rxBindingVersion = '3.1.0'
6363

6464
daggerVersion = '2.57'
6565

@@ -189,9 +189,9 @@ ext {
189189
okHttpDigest : "io.github.rburgst:okhttp-digest:${okHttpDigestVersion}",
190190
pcloud : "com.github.cryptomator.pcloud-sdk-java:java-core:${pcloudVersion}",
191191
recyclerViewFastScroll : "com.simplecityapps:recyclerview-fastscroll:${recyclerViewFastScrollVersion}",
192-
rxJava : "io.reactivex.rxjava2:rxjava:${rxJavaVersion}",
193-
rxAndroid : "io.reactivex.rxjava2:rxandroid:${rxAndroidVersion}",
194-
rxBinding : "com.jakewharton.rxbinding2:rxbinding:${rxBindingVersion}",
192+
rxJava : "io.reactivex.rxjava3:rxjava:${rxJavaVersion}",
193+
rxAndroid : "io.reactivex.rxjava3:rxandroid:${rxAndroidVersion}",
194+
rxBinding : "com.jakewharton.rxbinding3:rxbinding:${rxBindingVersion}",
195195
stax : "stax:stax:${staxVersion}",
196196
testingSupportLib : "com.android.support.test:testing-support-lib:${testingSupportLibVersion}",
197197
timber : "com.jakewharton.timber:timber:${timberVersion}",

domain/src/main/java/org/cryptomator/domain/executor/PostExecutionThread.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.cryptomator.domain.executor;
22

3-
import io.reactivex.Scheduler;
3+
import io.reactivex.rxjava3.core.Scheduler;
44

55
/**
66
* Thread abstraction created to change the execution context from any thread to any other thread.

generator/src/main/resources/templates/UseCaseTemplate.vm

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
1717

1818
private $implClassName impl;
1919
private org.cryptomator.domain.executor.BackgroundTasks.Registration registration;
20-
private io.reactivex.disposables.Disposable disposable = io.reactivex.internal.disposables.EmptyDisposable.INSTANCE;
20+
private io.reactivex.rxjava3.disposables.Disposable disposable = io.reactivex.rxjava3.disposables.Disposable.empty();
2121

2222
@javax.inject.Inject
2323
public ${simpleName}(
@@ -36,7 +36,10 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
3636
@Override
3737
public void unsubscribe() {
3838
if (disposable != null && !disposable.isDisposed()) {
39-
registration.unregister();
39+
if (registration != null) {
40+
registration.unregister();
41+
registration = null;
42+
}
4043
disposable.dispose();
4144
disposable = null;
4245
#if ( $hasCancelHandler )
@@ -101,7 +104,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
101104
#end
102105
);
103106
#if ( $hasProgressAware )
104-
final io.reactivex.subscribers.DisposableSubscriber<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>> subscriber = new io.reactivex.subscribers.DisposableSubscriber<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>>(){
107+
final io.reactivex.rxjava3.subscribers.DisposableSubscriber<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>> subscriber = new io.reactivex.rxjava3.subscribers.DisposableSubscriber<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>>(){
105108
@Override
106109
public void onComplete() {
107110
resultHandler.onFinished();
@@ -120,7 +123,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
120123
}
121124
};
122125
${simpleName}.this.disposable = subscriber;
123-
io.reactivex.Flowable.fromPublisher(new org.reactivestreams.Publisher<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>>(){
126+
io.reactivex.rxjava3.core.Flowable.fromPublisher(new org.reactivestreams.Publisher<org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>>(){
124127
public void subscribe(final org.reactivestreams.Subscriber<? super org.cryptomator.domain.usecases.ResultWithProgress<$resultClassName,$progressStateName>> subscriber) {
125128
org.cryptomator.domain.usecases.ProgressAware<$progressStateName> progressAware = new org.cryptomator.domain.usecases.ThrottlingProgressAware<$progressStateName>(new org.cryptomator.domain.usecases.ProgressAware<$progressStateName>() {
126129
@Override
@@ -152,7 +155,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
152155
}
153156
}
154157
#else
155-
final io.reactivex.subscribers.DisposableSubscriber<$subscriberResultClassName> subscriber = new io.reactivex.subscribers.DisposableSubscriber<$subscriberResultClassName>(){
158+
final io.reactivex.rxjava3.subscribers.DisposableSubscriber<$subscriberResultClassName> subscriber = new io.reactivex.rxjava3.subscribers.DisposableSubscriber<$subscriberResultClassName>(){
156159
@Override
157160
public void onComplete() {
158161
resultHandler.onFinished();
@@ -174,7 +177,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
174177
}
175178
};
176179
${simpleName}.this.disposable = subscriber;
177-
io.reactivex.Flowable.fromCallable(new java.util.concurrent.Callable<$subscriberResultClassName>(){
180+
io.reactivex.rxjava3.core.Flowable.fromCallable(new java.util.concurrent.Callable<$subscriberResultClassName>(){
178181
public $subscriberResultClassName call() throws Exception {
179182
final int id = EXECUTION_ID.getAndIncrement();
180183
boolean failed = true;
@@ -200,7 +203,7 @@ public class $simpleName implements org.cryptomator.generator.Unsubscribable {
200203
}
201204
#end
202205
})
203-
.subscribeOn(io.reactivex.schedulers.Schedulers.from(threadExecutor))
206+
.subscribeOn(io.reactivex.rxjava3.schedulers.Schedulers.from(threadExecutor))
204207
.onBackpressureLatest()
205208
.observeOn(postExecutionThread.getScheduler())
206209
.subscribe(subscriber);
@@ -229,7 +232,7 @@ public void run(final org.cryptomator.domain.usecases.ResultHandler<$resultClass
229232
#if( $foreach.hasNext ),#end
230233
#end
231234
);
232-
final io.reactivex.subscribers.DisposableSubscriber<$subscriberResultClassName> subscriber = new io.reactivex.subscribers.DisposableSubscriber<$subscriberResultClassName>(){
235+
final io.reactivex.rxjava3.subscribers.DisposableSubscriber<$subscriberResultClassName> subscriber = new io.reactivex.rxjava3.subscribers.DisposableSubscriber<$subscriberResultClassName>(){
233236
@Override
234237
public void onComplete() {
235238
resultHandler.onFinished();
@@ -251,7 +254,7 @@ public void run(final org.cryptomator.domain.usecases.ResultHandler<$resultClass
251254
}
252255
};
253256
this.disposable = subscriber;
254-
io.reactivex.Flowable.fromCallable(new java.util.concurrent.Callable<$subscriberResultClassName>(){
257+
io.reactivex.rxjava3.core.Flowable.fromCallable(new java.util.concurrent.Callable<$subscriberResultClassName>(){
255258
public $subscriberResultClassName call() throws Exception {
256259
final int id = EXECUTION_ID.getAndIncrement();
257260
boolean failed = true;
@@ -280,7 +283,7 @@ public void run(final org.cryptomator.domain.usecases.ResultHandler<$resultClass
280283
#end
281284
}
282285
})
283-
.subscribeOn(io.reactivex.schedulers.Schedulers.from(threadExecutor))
286+
.subscribeOn(io.reactivex.rxjava3.schedulers.Schedulers.from(threadExecutor))
284287
.observeOn(postExecutionThread.getScheduler())
285288
.subscribe(subscriber);
286289
}

presentation/src/main/java/org/cryptomator/presentation/UIThread.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ package org.cryptomator.presentation
33
import org.cryptomator.domain.executor.PostExecutionThread
44
import javax.inject.Inject
55
import javax.inject.Singleton
6-
import io.reactivex.Scheduler
7-
import io.reactivex.android.schedulers.AndroidSchedulers
6+
import io.reactivex.rxjava3.core.Scheduler
7+
import io.reactivex.rxjava3.android.schedulers.AndroidSchedulers
88

99
/**
1010
* MainThread (UI Thread) implementation based on a [io.reactivex.Scheduler]

presentation/src/main/java/org/cryptomator/presentation/util/PasswordStrengthUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import android.widget.ProgressBar;
77
import android.widget.TextView;
88

9-
import com.jakewharton.rxbinding2.widget.RxTextView;
9+
import com.jakewharton.rxbinding3.widget.RxTextView;
1010

1111
import java.util.List;
1212

0 commit comments

Comments
 (0)