forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 7
fix: staking cache to in-memory KV store #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
randy-cro
wants to merge
48
commits into
crypto-org-chain:release/v0.50.x
Choose a base branch
from
randy-cro:fix/staking-optimization
base: release/v0.50.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: staking cache to in-memory KV store #1733
randy-cro
wants to merge
48
commits into
crypto-org-chain:release/v0.50.x
from
randy-cro:fix/staking-optimization
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69b8ae9 to
88156ba
Compare
Author
@songgaoye it is here, did u miss it? |
b2f35a8 to
54ee8f5
Compare
54ee8f5 to
298069d
Compare
This was referenced Nov 12, 2025
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
This PR fixes inconsistencies in the staking cache (originally implemented in PR #1725) across different nodes.
Previously, simulation or optimistic execution contexts did not properly handle discarded changes, which could lead to duplicate or incorrect cache data, eventually causing apphash mismatches and halting the chain.
The primary change refactors the cache to use an in-memory KV store.
With this approach, when a context is discarded, the cache is automatically rolled back, just like any other store in the system.
This ensures that cache state remains consistent with the underlying store, even during simulations or optimistic execution scenarios.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change