BackupOriginalModule no return value and overwrite

Author: ViktorHofer

src/coverlet.core/Helpers/InstrumentationHelper.cs

@@ -78,11 +78,10 @@ public static bool HasPdb(string module)
             }
         }
 
-        public static string BackupOriginalModule(string module, string identifier)
+        public static void BackupOriginalModule(string module, string identifier)
         {
             var backupPath = GetBackupPath(module, identifier);
-            File.Copy(module, backupPath);
-            return backupPath;
+            File.Copy(module, backupPath, true);
         }
 
         public static void RestoreOriginalModule(string module, string identifier)

test/coverlet.core.tests/Helpers/InstrumentationHelperTests.cs

@@ -28,7 +28,12 @@ public void TestBackupOriginalModule()
             string module = typeof(InstrumentationHelperTests).Assembly.Location;
             string identifier = Guid.NewGuid().ToString();
 
-            var backupPath = InstrumentationHelper.BackupOriginalModule(module, identifier);
+            InstrumentationHelper.BackupOriginalModule(module, identifier);
+
+            var backupPath = Path.Combine(
+                Path.GetTempPath(),
+                Path.GetFileNameWithoutExtension(module) + "_" + identifier + ".dll"
+            );
 
             Assert.True(File.Exists(backupPath));
         }