Skip to content

Configurable sbt-launch-repo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Configurable sbt-launch-repo #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ make_url() {
make_coursier_url () {
local version="$1"

echo "https://github.com/coursier/sbt-launcher/releases/download/v$version/csbt"
local base="${sbt_launch_repo:-$(url_base "$version")}"

echo "$base/io/get-coursier/sbt-launcher_2.12/$version/sbt-launcher_2.12-$version.jar"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no io/get-coursier/sbt-launcher_2.12 anything under https://repo.scala-sbt.org/scalasbt/maven-releases.

And even if this were point to https://repo1.maven.org/maven2/io/get-coursier/sbt-launcher_2.12/1.2.19/sbt-launcher_2.12-1.2.19.jar I'm not 100% sure if that's equivalent to https://github.com/coursier/sbt-launcher/releases/download/v1.2.19/csbt (I remember something about Alex saying that there's a specific process in packaging coursier/sbt-launcher.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexarchambault so what needs to be done to make coursier/sbt-launcher equivalent to csbt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And even if this were point to https://repo1.maven.org/maven2/io/get-coursier/sbt-launcher_2.12/1.2.19/sbt-launcher_2.12-1.2.19.jar I'm not 100% sure if that's equivalent to https://github.com/coursier/sbt-launcher/releases/download/v1.2.19/csbt (I remember something about Alex saying that there's a specific process in packaging coursier/sbt-launcher.

Yes, the csbt jar at https://github.com/coursier/sbt-launcher/releases/download/v1.2.19/csbt is generated roughly with

$ cs bootstrap -o csbt sbt-launcher

It's a coursier "bootstrap", containing a list of URLs, which includes https://repo1.maven.org/maven2/io/get-coursier/sbt-launcher_2.12/1.2.19/sbt-launcher_2.12-1.2.19.jar and its dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sideeffffect IIUC, you'd like this JAR (csbt) to be downloaded from a repository of yours, rather than from GitHub?

For that to work, I think you'll have to generate your own csbt, like

$ cs bootstrap sbt-launcher:1.2.19 -o csbt --no-default -r https://your-custom-repo -r htttps://other-custom-repo

I guess that scenario would be made easier if / when the official sbt launcher were to be reworked based on https://github.com/coursier/sbt-launcher.

}

enable_coursier () {
Expand Down