-
Notifications
You must be signed in to change notification settings - Fork 161
remove npm #500
remove npm #500
Conversation
tests-solidity/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the original contributor for these, I don't have a strong preference between yarn and npm, but to bring awareness on my choice:
- I would strongly push against advocating for any npm module to be installed globally to run these tests (or really, to do any local-repo development)
- Yarn will be much, much faster at installing these test sub-packages, especially noticeable on CI environments
- If we do use npm, let's commit the
package-lock.json:). - Note that
npmdoes not come with its own monorepo capabilities, and so you would have to either script, uselerna, or go into each of the separate packages to install them before they can be run (since they require other dependencies than just truffle).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that yarn was less secure (I'm possibly wrong at this since the last time I used it continuously was in 2017-18), couldn't find any resources that backed this. Performance-wise, yarn is actually better than npm (see here and here). There's a community comparison between the two packages here.
In summary, I think we can undo the changes from this PR and use yarn everywhere (including docs) for the purpose of standardization.
c03c4ee to
ee1fb49
Compare
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't build the docs on http://localhost:8080/ using make docs-serve. I think the yarn methods don't require the run command: npm run serve -> yarn serve. Or maybe the yarn.lock file is wrong? afaik there's a cmd to migrate to yarn from npm
|
Okay not sure why the existing entities were not working but it works now |
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)