Skip to content

Conversation

@Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Oct 24, 2025

Overview

This PR patches over the logic from #7891 into openai-adapters. It converts Responses objects back into chat completion objects for streaming, implements ternary logic for streaming vs non-streaming defined in packages/openai-adapters/src/apis/base.ts, is non-stateful, and generally tries to adhere to the logic from #7891

Testing

Create a gpt5-codex-openai.yaml somewhere, e.g. continue/ root

name: GPT5 Codex Manual Test
version: 1.0.0
schema: v1

models:
  - name: openai-gpt5-codex
    provider: openai
    model: gpt-5-codex
    apiKey: <KEY>
    roles:
      - chat

then run npm run start -- --config /path/to/continue//gpt5-codex-openai.yaml and perform general smoke testing.

- Add GPT-5 Codex to llm-info package with 500k context and 150k max tokens
- Add model definition to models.ts for UI configuration
- Include GPT-5 Codex in OpenAI provider packages list
- Model supports chat and edit roles with tool_use capability
@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner October 24, 2025 01:34
@Patrick-Erichsen Patrick-Erichsen requested review from RomneyDa and removed request for a team October 24, 2025 01:34
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue API authentication failed. Please check your CONTINUE_API_KEY.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

RomneyDa
RomneyDa previously approved these changes Oct 28, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had several nitpicks but none are blocking. It would be nice to eliminate the >20 as any type casts

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 28, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes from recent commits (found 1 issue).

1 issue found across 3 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/openai-adapters/src/apis/openaiResponses.ts">

<violation number="1" location="packages/openai-adapters/src/apis/openaiResponses.ts:191">
Please pass the original ResponseOutputText part into createOutputTextPart so that annotations/logprobs survive the round-trip back into Responses payloads.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 6703362 into main Oct 29, 2025
84 of 87 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 29, 2025
@Patrick-Erichsen Patrick-Erichsen deleted the pe/gpt-5-oai branch October 29, 2025 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
@github-actions github-actions bot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Oct 29, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 29, 2025

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 29, 2025

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 29, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XXL This PR changes 1000+ lines, ignoring generated files. tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants