Skip to content

fix: better agent errors in settings agent section #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2025
Merged

fix: better agent errors in settings agent section #8198

merged 2 commits into from
Oct 14, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 11, 2025 •
edited by cubic-dev-ai bot
Loading

Description

  • Adds an optional uri to config validation errors to link source
  • Errors with URI are clickable in agent section and show border/cursor pointer when hovered
  • Adds uri to mcp json loading errors
image image

Summary by cubic

Improved error handling in the Agents settings: errors now show severity (red for fatal, yellow for warnings) and can link directly to the source config file. This makes MCP config issues faster to find and fix.

  • New Features
    • Added optional uri to ConfigValidationError and propagate it from MCP JSON/YAML loaders.
    • Errors with a uri are clickable in the Agents section and open the source file; hover shows pointer and border.
    • Clarified envFile warning text in JSON→YAML conversion.

@RomneyDa RomneyDa marked this pull request as ready for review October 11, 2025 07:02
@RomneyDa RomneyDa requested a review from a team as a code owner October 11, 2025 07:02
@RomneyDa RomneyDa requested review from sestinj and removed request for a team October 11, 2025 07:02
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 11, 2025
@github-actions
Copy link

github-actions bot commented Oct 11, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@sestinj sestinj merged commit fbaec42 into main Oct 14, 2025
43 checks passed
@sestinj sestinj deleted the dallin/better-mcp-error branch October 14, 2025 06:19
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@sestinj sestinj sestinj approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomneyDa @sestinj