Add a default None value for dockerimg variable #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@anton-khodak Currently Appveyor doesn't support docker testing, so we have promptly turned off tests that involves docker on appveyor |
Member
Author
|
hey @kapilkd13 , thanks for chiming in! I can't reproduce the failure from AppVeyor, the test succeeds on my Windows machine. It doesn't use a docker image, so I am confused why it fails. Any help in confirming whether the problem is in the test itself or AppVeyor configuration would be appreciated. |
Member
|
@anton-khodak Can you enhance the test to capture & report the output, not just the return code? |
Member
|
@anton-khodak Thanks. Any execution of a CWL tool under MS Windows requires docker, and hence can't be run on Appveyor. Can you tag this test so that it gets skipped under MS Windows? |
Member
|
Thank you @anton-khodak ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #552. Could be merged now, but I am going to add a test for this