add test for boolean type error

Author: mr-c

cwltool/main.py

@@ -285,10 +285,13 @@ def generate_parser(toolparser, tool, namemap):
             _logger.debug(u"Can't make command line argument from %s", inptype)
             return None
 
-        argument_kwargs = {'required': required, 'help': ahelp, 'action': action, 'default': default}
         if inptype != "boolean":
-            argument_kwargs['type'] = atype
-        toolparser.add_argument(flag + name, **argument_kwargs)
+            typekw = { 'type': atype }
+        else:
+            typekw = {}
+
+        toolparser.add_argument(flag + name, required=required,
+                help=ahelp, action=action, default=default, **typekw)
 
     return toolparser
 

tests/test_toolargparse.py

@@ -24,10 +24,37 @@ class ToolArgparse(unittest.TestCase):
       glob: test.txt
 stdout: test.txt
 baseCommand: [cat]
+'''
+
+    script2='''
+#!/usr/bin/env cwl-runner
+cwlVersion: 'cwl:draft-3'
+class: CommandLineTool
+inputs:
+  - id: bdg
+    type: "boolean"
+outputs:
+  - id: output
+    type: File
+    outputBinding:
+      glob: foo
+baseCommand:
+  - echo
+  - "ff"
+stdout: foo
 '''
 
     def test_help(self):
         with NamedTemporaryFile() as f:
             f.write(self.script)
             f.flush()
             self.assertEquals(main([f.name, '--input', 'README.rst']), 0)
+
+    def test_bool(self):
+        with NamedTemporaryFile() as f:
+            f.write(self.script2)
+            f.flush()
+            try:
+                self.assertEquals(main([f.name, '--help']), 0)
+            except SystemExit as e:
+                self.assertEquals(e.code, 0)