Skip to content

Honda Nidec: don't actuate while longitudinal is inactive #24028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Honda Nidec: don't actuate while longitudinal is inactive #24028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf6cd4
don't command any pcm_speed when long is not active
sshane Mar 23, 2022
65fa970
update refs
sshane Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion selfdrive/car/honda/carcontroller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def update(self, CC, CS):
0.5]
# The Honda ODYSSEY seems to have different PCM_ACCEL
# msgs, is it other cars too?
if self.CP.enableGasInterceptor:
if self.CP.enableGasInterceptor or not CC.longActive:
pcm_speed = 0.0
pcm_accel = int(0.0)
elif self.CP.carFingerprint in HONDA_NIDEC_ALT_PCM_ACCEL:
Expand Down
2 changes: 1 addition & 1 deletion selfdrive/test/process_replay/ref_commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
e740c2c793a5e2af19a5d52d7a4a45d77eca9412
5bf6cd4a8d3c96eb333ae58d81af3907ac8b2804