Reproduce and fix repeated watch-close failure on OS-X #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
lihaoyi
added a commit
to com-lihaoyi/mill
that referenced
this pull request
May 24, 2025
Pulls in com-lihaoyi/os-lib#393 and should fix #5167 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously after ~100 iterations, the provided
test("openClose")case stops receiving events from OS-X. Presumably we must be leaking somethingMoving most of the relevant
CarbonApi()calls into therunmethod so they all run on the same thread seems to make the problem go away. We still need one call running in constructor body for some reason, even if it doesn't do anything, because otherwise the calls in therunmethod seem to hangThe test case hangs on my macbook without this PR, passes with