vault: rename update() -> accumulateFlows()

Reason: update() is too generic, and can easily be
interpreted as changing the on-chain state, whereas
it actually updates the in-memory struct.

Co-Authored-By: Eric <[email protected]>
Co-Authored-By: Adam Uhlíř <[email protected]>

Author: 3 people

contracts/vault/Accounts.sol

@@ -76,7 +76,7 @@ library Accounts {
   /// outgoing and incoming flows up until the specified timestamp. Outgoing
   /// tokens are deducted from the available balance. Incoming tokens are added
   /// to the designated tokens.
-  function update(Account memory account, Timestamp timestamp) internal pure {
+  function accumulateFlows(Account memory account, Timestamp timestamp) internal pure {
     Duration duration = account.flow.updated.until(timestamp);
     account.balance.available -= account.flow.outgoing.accumulate(duration);
     account.balance.designated += account.flow.incoming.accumulate(duration);
@@ -86,7 +86,7 @@ library Accounts {
   /// Starts an incoming flow of tokens at the specified rate. If there already
   /// is a flow of incoming tokens, then its rate is increased accordingly.
   function flowIn(Account memory account, TokensPerSecond rate) internal view {
-    account.update(Timestamps.currentTime());
+    account.accumulateFlows(Timestamps.currentTime());
     account.flow.incoming = account.flow.incoming + rate;
   }
 
@@ -95,7 +95,7 @@ library Accounts {
   /// outgoing flow. If there are insuffient incoming tokens, then the outgoing
   /// rate is increased.
   function flowOut(Account memory account, TokensPerSecond rate) internal view {
-    account.update(Timestamps.currentTime());
+    account.accumulateFlows(Timestamps.currentTime());
     if (rate <= account.flow.incoming) {
       account.flow.incoming = account.flow.incoming - rate;
     } else {

contracts/vault/VaultBase.sol

@@ -82,12 +82,12 @@ abstract contract VaultBase {
     FundStatus status = fund.status();
     if (status == FundStatus.Locked) {
       Account memory account = _accounts[controller][fundId][accountId];
-      account.update(Timestamps.currentTime());
+      account.accumulateFlows(Timestamps.currentTime());
       return account.balance;
     }
     if (status == FundStatus.Withdrawing || status == FundStatus.Frozen) {
       Account memory account = _accounts[controller][fundId][accountId];
-      account.update(fund.flowEnd());
+      account.accumulateFlows(fund.flowEnd());
       return account.balance;
     }
     return Balance({available: 0, designated: 0});
@@ -255,7 +255,7 @@ abstract contract VaultBase {
     require(fund.status() == FundStatus.Withdrawing, VaultFundNotUnlocked());
 
     Account memory account = _accounts[controller][fundId][accountId];
-    account.update(fund.flowEnd());
+    account.accumulateFlows(fund.flowEnd());
     uint128 amount = account.balance.available + account.balance.designated;
 
     fund.value -= amount;