Skip to content

Commit 9abe591

Browse files
committed
Merge pull request #6 from tf/better-mobile-fix
Use new CSS class to prevent hidden text indicator
2 parents 8df90d5 + b55bcbd commit 9abe591

File tree

3 files changed

+2
-15
lines changed

3 files changed

+2
-15
lines changed

app/assets/javascript/pageflow/embedded_video/page_type.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ pageflow.pageType.register('embedded_video', _.extend({
66
enhance: function(pageElement, configuration) {
77
var that = this;
88

9-
pageElement.addClass('hide_content_with_text');
9+
pageElement.addClass('no_hidden_text_indicator');
1010

1111
if (pageflow.features.has('mobile platform')) {
1212
pageElement.find('.close_button, .iframe_container').click(function(event) {

app/assets/stylesheets/pageflow/embedded_video.css.scss

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,6 @@
11
@include pageflow-page-type(embedded_video);
22

33
.embedded_video_page {
4-
/*
5-
HACK: We need to set the hide_content_with_text css class on the
6-
page's section, to make the menu button and hide text text
7-
indicator disappear on mobile. But this also causes the content
8-
to be hidden, which we undo in the following. This should be
9-
decoupled in the pageflow gem.
10-
*/
11-
.content {
12-
visibility: visible !important;
13-
opacity: 1 !important;
14-
pointer-events: all !important;
15-
}
16-
174
.contentText {
185
margin-top: 40px;
196
}

pageflow-embedded-video.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
1414
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
1515
spec.require_paths = ["lib"]
1616

17-
spec.add_runtime_dependency "pageflow", "~> 0.7"
17+
spec.add_runtime_dependency "pageflow", "~> 0.10.pre"
1818
spec.add_runtime_dependency 'i18n-js'
1919

2020
spec.add_development_dependency "bundler"

0 commit comments

Comments
 (0)