This repository was archived by the owner on Apr 13, 2025. It is now read-only.
fix: build typescript in prepublish scripts #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem that the cli gets built before semantic-releaser updates the version. Because of this the released `0.1.0` shows `0.0.1` when running `nodecg-io --version` because it was built with that version which copies the `package.json` into the `build` directory. Then semantic-release updates the version and the copied `package.json` isn't updated. With this change we don't build the cli in a ci step anymore, but with the npm `prepublish` hook. That way semantic-release will bump the version and run `npm publish` which will then build the cli with the update version.
|
🎉 This PR is included in version 0.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hlxid
added a commit
that referenced
this pull request
May 8, 2021
Follow up on #12 `prepublish` does not run on `npm publish` KEKW, only `prepublishOnly` does. Brilliant naming!
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2021
## [0.1.2](v0.1.1...v0.1.2) (2021-05-08) ### Bug Fixes * build ts in prepublishOnly instead of prepublish because npm ([ab8cb09](ab8cb09)), closes [#12](#12)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that the cli gets built before semantic-releaser updates the version. Because of this the released
0.1.0shows0.0.1when runningnodecg-io --versionbecause it was built with that version which copies thepackage.jsoninto thebuilddirectory. Then semantic-release updates the version and the copiedpackage.jsonisn't updated.With this change we don't build the cli in a ci step anymore, but with the npm
prepublishhook. That way semantic-release will bump the version and runnpm publishwhich will then build the cli with the update version.