auth/rpc: remove unecessary chat membership check for message read rpcs

Jeff Yanta · Jeff Yanta · commit 615fc900b09a · 2025-03-13T15:01:24.000-04:00
diff --git a/auth/rpc/messaging.go b/auth/rpc/messaging.go
@@ -32,15 +32,15 @@ func NewMessagingRpcAuthorizer(chats chat.Store, intents intent.Store, messages
 }
 
 func (a *MessagingAuthorizer) CanStreamMessages(ctx context.Context, chatID *commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {
-	return a.chatMembershipCheck(ctx, chatID, userID)
+	return true, "", nil
 }
 
 func (a *MessagingAuthorizer) CanGetMessage(ctx context.Context, chatID *commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {
-	return a.chatMembershipCheck(ctx, chatID, userID)
+	return true, "", nil
 }
 
 func (a *MessagingAuthorizer) CanGetMessages(ctx context.Context, chatID *commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {
-	return a.chatMembershipCheck(ctx, chatID, userID)
+	return true, "", nil
 }
 
 // todo: This needs a refactor/cleanup because it's blowing up in size/complexity

Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,15 @@ func NewMessagingRpcAuthorizer(chats chat.Store, intents intent.Store, messages`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`func (a MessagingAuthorizer) CanStreamMessages(ctx context.Context, chatID commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {`
`35`		`- return a.chatMembershipCheck(ctx, chatID, userID)`
	`35`	`+ return true, "", nil`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`func (a MessagingAuthorizer) CanGetMessage(ctx context.Context, chatID commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {`
`39`		`- return a.chatMembershipCheck(ctx, chatID, userID)`
	`39`	`+ return true, "", nil`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`func (a MessagingAuthorizer) CanGetMessages(ctx context.Context, chatID commonpb.ChatId, userID *commonpb.UserId) (bool, string, error) {`
`43`		`- return a.chatMembershipCheck(ctx, chatID, userID)`
	`43`	`+ return true, "", nil`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`// todo: This needs a refactor/cleanup because it's blowing up in size/complexity`