Skip to content

fix: order of args in clear_cache positional bugs #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: order of args in clear_cache positional bugs #197

merged 2 commits into from
Oct 13, 2023

Conversation

@dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Oct 13, 2023

minor fix for if someone calls clear_cache(someDir) to reset the cache, rather than clear_cache(dir = someDir)

@dsweber2 dsweber2 merged commit ee952c5 into dev Oct 13, 2023
@dsweber2 dsweber2 deleted the clear_cache_positional_args branch October 13, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dshemetov dshemetov dshemetov approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsweber2 @dshemetov