Skip to content

Conversation

@dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Oct 6, 2023

Following R conventions on the owners, as its ambiguous which orgs exactly would hold. Also adding the particular rights claimed...

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs look right. Any idea why macos check is failing? Is that a preexisting or intermittent thing?

@dsweber2
Copy link
Contributor Author

dsweber2 commented Oct 6, 2023

   Error: 
  ! error in pak subprocess
  Caused by error in `file(con, "rb")`:
  ! cannot open the connection

🤔 not sure this is an us problem... I don't remember it happening before

Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there two license files (probably R pkgdown needs the Markdown?). Why are they different?

@dsweber2
Copy link
Contributor Author

dsweber2 commented Oct 9, 2023

It's what usethis::use_mit_license() generates, for whatever reason, so I just went with that

@dsweber2 dsweber2 merged commit c041a90 into dev Oct 9, 2023
@dsweber2 dsweber2 deleted the license branch October 9, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants