Skip to content

Feat: Add Broker Node Security Groups #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Feat: Add Broker Node Security Groups #41

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a899cea
Add broker_node_security_groups
nitrocode Oct 25, 2021
426730b
Add broker_node_security_groups
nitrocode Oct 25, 2021
995a283
Auto Format
cloudpossebot Oct 25, 2021
7d42a92
Add broker_node_security_groups to readme
nitrocode Oct 25, 2021
2dce0a1
Auto Format
cloudpossebot Oct 25, 2021
1463f70
Update main.tf
nitrocode Oct 25, 2021
61e5682
Restrict security groups based on enabled protocols.
korenyoni Oct 25, 2021
6e464ee
Use Security Group module.
korenyoni Oct 26, 2021
3963055
Auto Format
cloudpossebot Oct 26, 2021
fce6147
Bump minimum Terraform version to support SG module.
korenyoni Oct 26, 2021
cd3cddf
Auto Format
cloudpossebot Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ resource "aws_msk_cluster" "default" {
instance_type = var.broker_instance_type
ebs_volume_size = var.broker_volume_size
client_subnets = var.subnet_ids
security_groups = aws_security_group.default.*.id
security_groups = concat(var.broker_node_security_groups, aws_security_group.default.*.id)
}

configuration_info {
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ variable "security_groups" {
description = "List of security group IDs to be allowed to connect to the cluster"
}

variable "broker_node_security_groups" {
type = list(string)
default = []
description = "List of broker node security group IDs to be associated with the elastic network interfaces to control who can communicate with the cluster"
}

variable "allowed_cidr_blocks" {
type = list(string)
default = []
Expand Down