Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 14, 2019

Bumps jackson-bom from 2.9.3 to 2.10.1.

Commits
  • ba3682a [maven-release-plugin] prepare release jackson-bom-2.10.1
  • ed13e3e Prepare for 2.10.1 release
  • 8e5b31b Remove sonatype deploy pluging from jackson-bom, just in case it might interf...
  • 395487c actually revert change for just a bit until actual release
  • 2b32e18 prepare for 2.10.1 (but not today)
  • bc50d26 Add sonatype deploy plugin to simplify deployment
  • 658a2a5 move to 2.10.1-SNAPSHOT
  • 98a0a00 [maven-release-plugin] prepare for next development iteration
  • 757c490 [maven-release-plugin] prepare release jackson-bom-2.10.0
  • 874d731 Prepare for 2.10.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Nov 14, 2019
@aheritier
Copy link
Contributor

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.10.1 branch from bc96093 to 53b24b1 Compare November 22, 2019 18:52
@aheritier
Copy link
Contributor

Strange

00:07
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-bytecode-version) @ zendesk-java-client ---
00:07
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile contains module-info.class targeted to JDK 1.9
00:07
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile contains module-info.class targeted to JDK 1.9
00:07
[INFO] Restricted to JDK 1.8 yet com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile contains module-info.class targeted to JDK 1.9
00:07
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
00:07
Found Banned Dependency: com.fasterxml.jackson.core:jackson-databind:jar:2.10.1
00:07
Found Banned Dependency: com.fasterxml.jackson.core:jackson-core:jar:2.10.1
00:07
Found Banned Dependency: com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1
00:07
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

Let's see if enforcer upgrades are fixing it. The result is erroneous. It's not because you have a J9+ module-info.class that your lib is for J9+ only

@aheritier
Copy link
Contributor

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.10.1 branch from 53b24b1 to ae237d9 Compare November 22, 2019 19:11
Copy link
Contributor

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good it is fixed. Our enforcer rules were too old

@dependabot-preview dependabot-preview bot merged commit 24d7eba into master Nov 22, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.10.1 branch November 22, 2019 19:19
@aheritier aheritier added this to the 0.10.0 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants