Fix Action model value type

Author: Dohbedoh

src/main/java/org/zendesk/client/v2/model/Action.java

@@ -14,7 +14,7 @@ public class Action {
 
     @JsonFormat(with = {JsonFormat.Feature.ACCEPT_SINGLE_VALUE_AS_ARRAY,
             JsonFormat.Feature.WRITE_SINGLE_ELEM_ARRAYS_UNWRAPPED})
-    private String[] value;
+    private Object[] value;
 
     public Action() {
     }
@@ -32,11 +32,11 @@ public void setField(String field) {
         this.field = field;
     }
 
-    public String[] getValue() {
+    public Object[] getValue() {
         return value;
     }
 
-    public void setValue(String[] value) {
+    public void setValue(Object[] value) {
         this.value = value;
     }
 

src/test/java/org/zendesk/client/v2/model/TriggerTest.java

@@ -0,0 +1,64 @@
+package org.zendesk.client.v2.model;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class TriggerTest {
+
+    private Trigger parseJson(byte[] json) {
+        ObjectMapper mapper = new ObjectMapper();
+        try {
+            return mapper.readValue(json, Trigger.class);
+        } catch (Exception e) {
+            e.printStackTrace();
+            return null;
+        }
+    }
+
+    private byte [] writeJson(Trigger trigger) throws JsonProcessingException {
+        return new ObjectMapper().writeValueAsBytes(trigger);
+    }
+
+    @Test
+    public void testTriggerWithComplexActionValues() throws Exception {
+        String json = "{\"id\":12345678,\"title\":\"Test Trigger\",\"active\":true,\"position\":45,\"conditions\":{\"all\":[],\"any\":[{\"field\":\"comment_includes_word\",\"operator\":\"includes\",\"value\":\"@triggerTest\"}]},\"actions\":[{\"field\":\"notification_target\",\"value\":[\"1234567890\",[[\"key1\",\"value1\"],[\"key2\",\"value2\"]]]}],\"createdAt\":null,\"updatedAt\":null}";
+        Trigger trigger = parseJson(json.getBytes());
+        assertNotNull(trigger);
+        assertEquals("Test Trigger", trigger.getTitle());
+        assertEquals(1, trigger.getActions().size());
+        assertEquals("notification_target", trigger.getActions().get(0).getField());
+        assertArrayEquals(new Object [] {"1234567890", Arrays.asList(Arrays.asList("key1", "value1"), Arrays.asList("key2", "value2"))}, trigger.getActions().get(0).getValue());
+        assertEquals(0, trigger.getConditions().getAll().size());
+        assertEquals(1, trigger.getConditions().getAny().size());
+        assertEquals("comment_includes_word", trigger.getConditions().getAny().get(0).getField());
+        assertEquals("includes", trigger.getConditions().getAny().get(0).getOperator());
+        assertEquals("@triggerTest", trigger.getConditions().getAny().get(0).getValue());
+        assertEquals(json, new String(writeJson(trigger)));
+    }
+
+    @Test
+    public void testTriggerWithMultilineActionValues() throws Exception {
+        String json = "{\"id\":12345678,\"title\":\"Test Trigger\",\"active\":true,\"position\":45,\"conditions\":{\"all\":[],\"any\":[{\"field\":\"comment_includes_word\",\"operator\":\"includes\",\"value\":\"@triggerTest\"}]},\"actions\":[{\"field\":\"notification_user\",\"value\":[\"09876543\",\"Trigger Target 1 {{ticket.title}}\",\"Test Multiline\\n\\n{{ticket.comments_formatted}}\\n\\n--------------------------\"]},{\"field\":\"notification_target\",\"value\":[\"98765432\",\"{\\n  \\\"color\\\":\\\"purple\\\",\\n  \\\"message_format\\\":\\\"text\\\",\\n  \\\"message\\\":\\\"Trigger Target 2 {{ticket.title}}.\\\"\\n}\"]}],\"createdAt\":null,\"updatedAt\":null}";
+        Trigger trigger = parseJson(json.getBytes());
+        assertNotNull(trigger);
+        assertEquals("Test Trigger", trigger.getTitle());
+        assertEquals(2, trigger.getActions().size());
+        assertEquals("notification_user", trigger.getActions().get(0).getField());
+        assertArrayEquals(new String [] {"09876543", "Trigger Target 1 {{ticket.title}}", "Test Multiline\n\n{{ticket.comments_formatted}}\n\n--------------------------"}, trigger.getActions().get(0).getValue());
+        assertEquals("notification_target", trigger.getActions().get(1).getField());
+        assertArrayEquals(new String [] {"98765432", "{\n  \"color\":\"purple\",\n  \"message_format\":\"text\",\n  \"message\":\"Trigger Target 2 {{ticket.title}}.\"\n}"}, trigger.getActions().get(1).getValue());
+        assertEquals(0, trigger.getConditions().getAll().size());
+        assertEquals(1, trigger.getConditions().getAny().size());
+        assertEquals("comment_includes_word", trigger.getConditions().getAny().get(0).getField());
+        assertEquals("includes", trigger.getConditions().getAny().get(0).getOperator());
+        assertEquals("@triggerTest", trigger.getConditions().getAny().get(0).getValue());
+        assertEquals(json, new String(writeJson(trigger)));
+    }
+}