Rename cider-switch-to-repl-on-insert without -p suffix

Author: dpsutton

CHANGELOG.md

@@ -11,7 +11,7 @@
 
 ### Changes
 
-* * Add new defcustom `cider-switch-to-repl-on-insert-p`: Set to prevent cursor from going to the repl when inserting a form in the repl with the insert-to-repl commands. Replaces obsoleted `cider-switch-to-repl-after-insert-p`
+* * Add new defcustom `cider-switch-to-repl-on-insert`: Set to prevent cursor from going to the repl when inserting a form in the repl with the insert-to-repl commands. Replaces obsoleted `cider-switch-to-repl-after-insert-p`
 * **(Breaking)** Upgrade to nREPL 0.6.0. This is now the minimum required version.
 * **(Breaking)** Upgrade to piggieback 0.4.0. This is now the minimum required version.
 * **(Breaking)** Remove `cider.nrepl.middleware.pprint`. All functionality has been replaced by the built-in printing support in nREPL 0.6.

cider-mode.el

@@ -223,15 +223,15 @@ With a prefix argument, prompt for function to run instead of -main."
   :group 'cider
   :package-version '(cider . "0.18.0"))
 
-(defcustom cider-switch-to-repl-on-insert-p t
+(defcustom cider-switch-to-repl-on-insert t
   "Whether to switch to the repl when inserting a form into the repl."
   :type 'boolean
   :group 'cider
   :package-version '(cider . "0.21.0"))
 
 (define-obsolete-variable-alias
   'cider-switch-to-repl-after-insert-p
-  'cider-switch-to-repl-on-insert-p
+  'cider-switch-to-repl-on-insert
   "0.21.0")
 
 (defcustom cider-invert-insert-eval-p nil
@@ -249,7 +249,7 @@ If EVAL is non-nil the form will also be evaluated.  Use
 `cider-invert-insert-eval-p' to invert this behavior."
   (while (string-match "\\`[ \t\n\r]+\\|[ \t\n\r]+\\'" form)
     (setq form (replace-match "" t t form)))
-  (when cider-switch-to-repl-on-insert-p
+  (when cider-switch-to-repl-on-insert
     (cider-switch-to-repl-buffer))
   (let ((repl (cider-current-repl)))
     (with-selected-window (or (get-buffer-window repl)