From 2f8c0134eaa870a3a2d664ca837f5ebb80bd6de2 Mon Sep 17 00:00:00 2001 From: joshua-spacetime Date: Fri, 9 Feb 2024 18:01:24 -0800 Subject: [PATCH] perf(subscriptions): Add metric counter for subscribe calls --- crates/core/src/subscription/module_subscription_actor.rs | 4 ++++ crates/core/src/worker_metrics/mod.rs | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/crates/core/src/subscription/module_subscription_actor.rs b/crates/core/src/subscription/module_subscription_actor.rs index 5ee961a7264..7c397b45cc9 100644 --- a/crates/core/src/subscription/module_subscription_actor.rs +++ b/crates/core/src/subscription/module_subscription_actor.rs @@ -67,6 +67,10 @@ impl ModuleSubscriptions { } }; + WORKER_METRICS + .initial_subscription_evals + .with_label_values(&self.relational_db.address()) + .inc(); let database_update = tokio::task::block_in_place(|| subscription.queries.eval(&self.relational_db, tx, auth))?; let sender = subscription.subscribers().last().unwrap(); diff --git a/crates/core/src/worker_metrics/mod.rs b/crates/core/src/worker_metrics/mod.rs index 902327059f5..9e6b8b2cc97 100644 --- a/crates/core/src/worker_metrics/mod.rs +++ b/crates/core/src/worker_metrics/mod.rs @@ -82,6 +82,11 @@ metrics_group!( #[labels(identity: Identity, module_hash: Hash, database_address: Address, reducer_symbol: str)] pub wasm_instance_errors: IntCounterVec, + #[name = spacetime_initial_subscription_evals] + #[help = "The cumulative number of initial subscription evaluations"] + #[labels(database_address: Address)] + pub initial_subscription_evals: IntCounterVec, + #[name = spacetime_active_queries] #[help = "The number of active subscription queries"] #[labels(database_address: Address)]