Skip to content

Conversation

@jdetter
Copy link
Collaborator

@jdetter jdetter commented Jul 1, 2023

Description of Changes

  • Smoketests now run in parallel
    • I acheived this by isolating each test in its own temporary directory while its running.
    • Some tests like the restart tests still cannot be parallelized so those tests are ran sequentially at the conclusion of all the parallel tests.
  • I had to make some small changes to the way saving/loading config files work. If you specify SPACETIME_CONFIG_FILE as an environment variable, then that file will be used for both saving and loading. Before this PR we would only load the contents of the SPACETIME_CONFIG_FILE and we would still write to the default file location.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@jdetter jdetter force-pushed the jdetter/parallel-smoketests branch from 074d225 to ce4c50e Compare July 13, 2023 21:45
@jdetter jdetter marked this pull request as ready for review July 13, 2023 22:34
@jdetter jdetter requested a review from cloutiertyler July 13, 2023 22:34
@jdetter jdetter force-pushed the jdetter/parallel-smoketests branch from 3490f99 to bcbfa89 Compare July 13, 2023 22:41
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT LGTM

@jdetter jdetter merged commit e2cdcd2 into master Jul 13, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Working on improving commands that use identities

* Fix lints

* Reverted file that shouldn't have changed

* Found and fixed all other todos

* Addressed more CLI TODOs

* Fixes for formatting issues

* Set names of identities

* Set name of identities + clippy

* Small fix

* Added the start of a doc comment, switching over to another PR

* Fixed tests that needed to be updated

* Addressed more feedback and fixed several clippy issues

* Small fix

* Apply suggestions from code review

Co-authored-by: Mazdak Farrokhzad <[email protected]>
Signed-off-by: John Detter <[email protected]>

* Added more doc comments

* Addressing more feedback

* Fixed really old bug in SpacetimeDB

* Tests to verify new functionality

* Fix clippy lints

* Email during identity creation is optional

* Some work

* Getting smoketests working on mac

* All tests are passing except known failing tests

* Working on parallel smoketests

* Fixed some bugs in saving configs that was preventing this from working

* Fixes required for parallel tests

* Tests are working in parallel

* Pruned changes

* retab

* re-retab

* retab the lib file

* Cargo profile for building more quickly

* I have to rebase on another PR

* smoketest fixes

* create_project and reset_project are now the same thing, removed
create_project

* More fixes

* Removed print statement

* Small fix

* Another fix

* Tons of improvements to the smoketests

* Have to rebase on master

* Small fixes

* More progress

* Finally working correctly!

* Apparently we're missing this

* Enable command output

* Listing installed targets

* Clean before building

* What is going on

* Something super wonky going on

* Another test

* Skip building containers for now

* Small fix

* Test using cargo instead

* Changed workflow a bit

* CI is stuck

* Small fix

* Another fix

* Try cargo run instead of building spacetime CLI

* Removed workflow step

* Fixing all of the tests

* Identity test

* Tests should finally be working

* Enable debug

* Remove spacetime from path

* Another try

* Logic fix

* Another fix

* Another fix

* Working now?

* Another fix

* Finally working again

* Adding github containers back in

* CI fix

* Use SpacetimeDB Large Runner

* Updated test to get more output

* Changed 0ms to 10ms to improve parallel test stability

* Removed unused logs

Signed-off-by: John Detter <[email protected]>

* Removed unnecessary reset_project

* Removed reset_config where its not needed

* Reset template

---------

Signed-off-by: John Detter <[email protected]>
Co-authored-by: Boppy <[email protected]>
Co-authored-by: Mazdak Farrokhzad <[email protected]>
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Working on improving commands that use identities

* Fix lints

* Reverted file that shouldn't have changed

* Found and fixed all other todos

* Addressed more CLI TODOs

* Fixes for formatting issues

* Set names of identities

* Set name of identities + clippy

* Small fix

* Added the start of a doc comment, switching over to another PR

* Fixed tests that needed to be updated

* Addressed more feedback and fixed several clippy issues

* Small fix

* Apply suggestions from code review

Co-authored-by: Mazdak Farrokhzad <[email protected]>
Signed-off-by: John Detter <[email protected]>

* Added more doc comments

* Addressing more feedback

* Fixed really old bug in SpacetimeDB

* Tests to verify new functionality

* Fix clippy lints

* Email during identity creation is optional

* Some work

* Getting smoketests working on mac

* All tests are passing except known failing tests

* Working on parallel smoketests

* Fixed some bugs in saving configs that was preventing this from working

* Fixes required for parallel tests

* Tests are working in parallel

* Pruned changes

* retab

* re-retab

* retab the lib file

* Cargo profile for building more quickly

* I have to rebase on another PR

* smoketest fixes

* create_project and reset_project are now the same thing, removed
create_project

* More fixes

* Removed print statement

* Small fix

* Another fix

* Tons of improvements to the smoketests

* Have to rebase on master

* Small fixes

* More progress

* Finally working correctly!

* Apparently we're missing this

* Enable command output

* Listing installed targets

* Clean before building

* What is going on

* Something super wonky going on

* Another test

* Skip building containers for now

* Small fix

* Test using cargo instead

* Changed workflow a bit

* CI is stuck

* Small fix

* Another fix

* Try cargo run instead of building spacetime CLI

* Removed workflow step

* Fixing all of the tests

* Identity test

* Tests should finally be working

* Enable debug

* Remove spacetime from path

* Another try

* Logic fix

* Another fix

* Another fix

* Working now?

* Another fix

* Finally working again

* Adding github containers back in

* CI fix

* Use SpacetimeDB Large Runner

* Updated test to get more output

* Changed 0ms to 10ms to improve parallel test stability

* Removed unused logs

Signed-off-by: John Detter <[email protected]>

* Removed unnecessary reset_project

* Removed reset_config where its not needed

* Reset template

---------

Signed-off-by: John Detter <[email protected]>
Co-authored-by: Boppy <[email protected]>
Co-authored-by: Mazdak Farrokhzad <[email protected]>
@cloutiertyler cloutiertyler deleted the jdetter/parallel-smoketests branch August 1, 2023 21:56
bfops pushed a commit that referenced this pull request Jul 17, 2025
* One-off query support (#49)

* SpacetimeDBURI argument in place of host and ssl enabled bool (#52)

* SpacetimeDBURI argument in place of host and ssl enabled bool

* Small cleanup

---------

Co-authored-by: John Detter <[email protected]>

* Add support for client address; re-run `spacetime generate` for quickstart client (#54)

* README.md and License.txt updates (#53)

* Update README.md

* Add license.txt

* Rename

* Add LICENSE.txt with proper case

---------

Co-authored-by: Derek Brinkmann <[email protected]>

* Add support for client address; re-run `spacetime generate` for quickstart client

Re: #299

---------

Co-authored-by: dbrinkmanncw <[email protected]>
Co-authored-by: Derek Brinkmann <[email protected]>

* Making Quickstart Work Again (#57)

* Packaged nuget package, quickstart is now working again

* Reset DBNAME

---------

Co-authored-by: John Detter <[email protected]>

* OnUnhandledReducerError (#31)

Co-authored-by: Steve <[email protected]>
Co-authored-by: Boppy <[email protected]>

---------

Co-authored-by: james gilles <[email protected]>
Co-authored-by: dbrinkmanncw <[email protected]>
Co-authored-by: John Detter <[email protected]>
Co-authored-by: Phoebe Goldman <[email protected]>
Co-authored-by: Derek Brinkmann <[email protected]>
Co-authored-by: SteveBoytsun <[email protected]>
Co-authored-by: Steve <[email protected]>
bfops pushed a commit that referenced this pull request Aug 7, 2025
* One-off query support (#49)

* SpacetimeDBURI argument in place of host and ssl enabled bool (#52)

* SpacetimeDBURI argument in place of host and ssl enabled bool

* Small cleanup

---------

Co-authored-by: John Detter <[email protected]>

* Add support for client address; re-run `spacetime generate` for quickstart client (#54)

* README.md and License.txt updates (#53)

* Update README.md

* Add license.txt

* Rename

* Add LICENSE.txt with proper case

---------

Co-authored-by: Derek Brinkmann <[email protected]>

* Add support for client address; re-run `spacetime generate` for quickstart client

Re: #299

---------

Co-authored-by: dbrinkmanncw <[email protected]>
Co-authored-by: Derek Brinkmann <[email protected]>

* Making Quickstart Work Again (#57)

* Packaged nuget package, quickstart is now working again

* Reset DBNAME

---------

Co-authored-by: John Detter <[email protected]>

* OnUnhandledReducerError (#31)

Co-authored-by: Steve <[email protected]>
Co-authored-by: Boppy <[email protected]>

---------

Co-authored-by: james gilles <[email protected]>
Co-authored-by: dbrinkmanncw <[email protected]>
Co-authored-by: John Detter <[email protected]>
Co-authored-by: Phoebe Goldman <[email protected]>
Co-authored-by: Derek Brinkmann <[email protected]>
Co-authored-by: SteveBoytsun <[email protected]>
Co-authored-by: Steve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants