Remove unused datastore traits #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously anticipated factoring the database in such a way that the typed vs untyped distinctions, and the transactional vs not, semantics would be more visible. We have not used these distinctions and no longer need to expose these traits.
joshua-spacetime
approved these changes
Aug 8, 2023
Centril
approved these changes
Aug 9, 2023
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* Co-authored-by: John Detter <[email protected]>
bfops
added a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes Release these changes: ``` f376c05 0.12.0 DLLs (again) (#161) c3be5b0 Update to tests/examples follow codegen changes (#160) d2143cc Use SpacetimeDBNetworkManager everywhere (#157) 072d9ea Upgrade SDK Version to 0.12 (#156) 2d20acd Fix UnityNetworkManager (#141) 434c5ff Accept multiple queries in Subscribe (#153) b320e5e Update DLLs for 0.12.0 (#152) 1b0e843 Jeremie/remove break (#154) 2c95bee Try to catch flaky bugs (#150) 76d275f Remove obsolete tools folder (#149) b96f1a6 Fix `gen-client-api` scripts for new CLI API (#151) affa2af Add script to generate `nuget.config` (#115) fa87e36 Don't actually try to connect to network in tests (#144) 9d3336e Reduce public API surface further (#145) 463a240 Tighten package sources in C# smoketests (#133) cec6fb8 Fix UnityDebugLogger implementation (#143) b62a464 Implement websocket changes atop C# sdk changes (#136) cfd654f Hide more APIs (#140) 113e8dd Add DbConnection argument to OnConnect (#138) 87a13eb Merge table cache into table handle (#139) 5c033a4 Subscription API (#137) 76d30fe c# client SDK (DbConnection + SDK Callbacks) (#131) 589d404 Logging API (#132) 6312c45 Copy files from old repo (#127) 2422b8c Nix `Primitives.cs` - types now defined in main repo (#120) 5670db6 Update DEVELOP.md to reflect new codegen (#119) 341be7f Restore `dotnet pack` functionality (#118) e57e589 Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 (#116) ``` ## API Almost certainly a breaking change ## Requires SpacetimeDB PRs Requires version 0.12.0 in SpacetimeDB --------- Co-authored-by: Mazdak Farrokhzad <[email protected]> Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: Jeremie Pelletier <[email protected]> Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: SteveGibson <[email protected]> Co-authored-by: Steve Boytsun <[email protected]> Co-authored-by: John Detter <[email protected]> Co-authored-by: John Detter <[email protected]>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* Co-authored-by: John Detter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously anticipated factoring the database in such a way that the typed vs untyped distinctions, and the transactional vs not, semantics would be more visible. We have not used these distinctions and no longer need to expose these traits.
Description of Changes
API
If the API is breaking, please state below what will break