Remove support for the update reducer
#1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In favor of migrations providing similar and more powerful functionality. Also remove traces of the `migrate` reducer, for the same reasons.
Centril
approved these changes
Jul 30, 2024
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Some minor suggestions for a follow up, this PR, or to ignore if you like.
Comment on lines
+599
to
+607
| let res = if stored == program.hash { | ||
| info!("database `{}` up to date with program `{}`", addr, program.hash); | ||
| Ok(()) | ||
| } else { | ||
| info!("updating `{}` from {} to {}", addr, stored, program.hash); | ||
| module.update_database(program.hash, program.bytes).await? | ||
| }; | ||
|
|
||
| Ok(res) |
Contributor
There was a problem hiding this comment.
Suggested change
| let res = if stored == program.hash { | |
| info!("database `{}` up to date with program `{}`", addr, program.hash); | |
| Ok(()) | |
| } else { | |
| info!("updating `{}` from {} to {}", addr, stored, program.hash); | |
| module.update_database(program.hash, program.bytes).await? | |
| }; | |
| Ok(res) | |
| Ok(if stored == program.hash { | |
| info!("database `{}` up to date with program `{}`", addr, program.hash); | |
| Ok(()) | |
| } else { | |
| info!("updating `{}` from {} to {}", addr, stored, program.hash); | |
| module.update_database(program.hash, program.bytes).await? | |
| }) |
gefjon
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for the
updatereducerIn favor of migrations providing similar and more powerful functionality.
Also remove traces of the
migratereducer, for the same reasons.API and ABI breaking changes
Modules using
#[spacetimedb(update)]will no longer compile.Expected complexity and risk
2
Testing
Should work as before.