Skip to content

Commit 17efe2b

Browse files
perf(610): More granular histogram buckets for timing metrics
Closes #610.
1 parent 4090777 commit 17efe2b

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

crates/core/src/db/db_metrics/mod.rs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,17 @@ metrics_group!(
9191
#[name = spacetime_txn_elapsed_time_sec]
9292
#[help = "The total elapsed (wall) time of a transaction (in seconds)"]
9393
#[labels(txn_type: WorkloadType, db: Address, reducer: str)]
94+
#[buckets(
95+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
96+
)]
9497
pub rdb_txn_elapsed_time_sec: HistogramVec,
9598

9699
#[name = spacetime_txn_cpu_time_sec]
97100
#[help = "The time spent executing a transaction (in seconds), excluding time spent waiting to acquire database locks"]
98101
#[labels(txn_type: WorkloadType, db: Address, reducer: str)]
102+
#[buckets(
103+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
104+
)]
99105
pub rdb_txn_cpu_time_sec: HistogramVec,
100106

101107
#[name = spacetime_txn_cpu_time_sec_max]
@@ -106,6 +112,9 @@ metrics_group!(
106112
#[name = spacetime_query_cpu_time_sec]
107113
#[help = "The time spent executing a query (in seconds)"]
108114
#[labels(txn_type: WorkloadType, db: Address, query: str)]
115+
#[buckets(
116+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
117+
)]
109118
pub rdb_query_cpu_time_sec: HistogramVec,
110119

111120
#[name = spacetime_query_cpu_time_sec_max]
@@ -116,6 +125,9 @@ metrics_group!(
116125
#[name = spacetime_query_compile_time_sec]
117126
#[help = "The time spent compiling a query (in seconds)"]
118127
#[labels(txn_type: WorkloadType, db: Address, query: str)]
128+
#[buckets(
129+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
130+
)]
119131
pub rdb_query_compile_time_sec: HistogramVec,
120132

121133
#[name = spacetime_query_compile_time_sec_max]
@@ -126,6 +138,9 @@ metrics_group!(
126138
#[name = spacetime_wasm_abi_call_duration_sec]
127139
#[help = "The total duration of a spacetime wasm abi call (in seconds); includes row serialization and copying into wasm memory"]
128140
#[labels(db: Address, reducer: str, call: AbiCall)]
141+
#[buckets(
142+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
143+
)]
129144
pub wasm_abi_call_duration_sec: HistogramVec,
130145

131146
#[name = spacetime_message_log_size_bytes]

crates/core/src/worker_metrics/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ metrics_group!(
8686
#[name = spacetime_scheduled_reducer_delay_sec]
8787
#[help = "The amount of time (in seconds) a reducer has been delayed past its scheduled execution time"]
8888
#[labels(db: Address, reducer: str)]
89+
#[buckets(
90+
1e-6, 5e-6, 1e-5, 5e-5, 1e-4, 5e-4, 1e-3, 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0
91+
)]
8992
pub scheduled_reducer_delay_sec: HistogramVec,
9093

9194
#[name = spacetime_scheduled_reducer_delay_sec_max]

0 commit comments

Comments
 (0)