Skip to content

Commit 4c7aa49

Browse files
authored
Merge pull request #138 from chrisglein/fabric_packaged
Update Fabric to use modern packaged app template
2 parents 6cb3753 + 28adefb commit 4c7aa49

File tree

113 files changed

+4375
-3456
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+4375
-3456
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
module.exports = {
22
root: true,
3-
extends: '@react-native-community',
3+
extends: '@react-native',
44
};

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,8 @@ yarn-error.log
6262
# Temporary files created by Metro to check the health of the file watcher
6363
.metro-health-check*
6464

65+
# testing
66+
/coverage
67+
6568
# Build logs
6669
*.binlog

.node-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

.ruby-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

.vscode/.react/debuggerWorker.js

Lines changed: 0 additions & 202 deletions
This file was deleted.

.watchmanconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{}
1+
{}

Gemfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
source 'https://rubygems.org'
22

33
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
4-
ruby File.read(File.join(__dir__, '.ruby-version')).strip
4+
ruby ">= 2.6.10"
55

6-
gem 'cocoapods', '~> 1.11', '>= 1.11.3'
6+
gem 'cocoapods', '~> 1.13'
7+
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'

__tests__/App-test.tsx renamed to __tests__/App.test.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44

55
import 'react-native';
66
import React from 'react';
7-
import App from '../App';
7+
import App from '../src/App';
8+
9+
// Note: import explicitly to use the types shipped with jest.
10+
import {it} from '@jest/globals';
811

912
// Note: test renderer must be required after react-native.
1013
import renderer from 'react-test-renderer';

android/app/build.gradle

Lines changed: 6 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
apply plugin: "com.android.application"
2+
apply plugin: "org.jetbrains.kotlin.android"
23
apply plugin: "com.facebook.react"
34

4-
import com.android.build.OutputFile
5-
65
/**
76
* This is the configuration block to customize your React Native Android app.
87
* By default you don't need to apply any configuration, just uncomment the lines you need.
@@ -12,9 +11,9 @@ react {
1211
// The root of your project, i.e. where "package.json" lives. Default is '..'
1312
// root = file("../")
1413
// The folder where the react-native NPM package is. Default is ../node_modules/react-native
15-
// reactNativeDir = file("../node-modules/react-native")
16-
// The folder where the react-native Codegen package is. Default is ../node_modules/react-native-codegen
17-
// codegenDir = file("../node-modules/react-native-codegen")
14+
// reactNativeDir = file("../node_modules/react-native")
15+
// The folder where the react-native Codegen package is. Default is ../node_modules/@react-native/codegen
16+
// codegenDir = file("../node_modules/@react-native/codegen")
1817
// The cli.js file which is the React Native CLI entrypoint. Default is ../node_modules/react-native/cli.js
1918
// cliFile = file("../node_modules/react-native/cli.js")
2019

@@ -52,14 +51,6 @@ react {
5251
// hermesFlags = ["-O", "-output-source-map"]
5352
}
5453

55-
/**
56-
* Set this to true to create four separate APKs instead of one,
57-
* one for each native architecture. This is useful if you don't
58-
* use App Bundles (https://developer.android.com/guide/app-bundle/)
59-
* and want to have separate APKs to upload to the Play Store.
60-
*/
61-
def enableSeparateBuildPerCPUArchitecture = false
62-
6354
/**
6455
* Set this to true to Run Proguard on Release builds to minify the Java bytecode.
6556
*/
@@ -78,20 +69,10 @@ def enableProguardInReleaseBuilds = false
7869
*/
7970
def jscFlavor = 'org.webkit:android-jsc:+'
8071

81-
/**
82-
* Private function to get the list of Native Architectures you want to build.
83-
* This reads the value from reactNativeArchitectures in your gradle.properties
84-
* file and works together with the --active-arch-only flag of react-native run-android.
85-
*/
86-
def reactNativeArchitectures() {
87-
def value = project.getProperties().get("reactNativeArchitectures")
88-
return value ? value.split(",") : ["armeabi-v7a", "x86", "x86_64", "arm64-v8a"]
89-
}
90-
9172
android {
9273
ndkVersion rootProject.ext.ndkVersion
93-
94-
compileSdkVersion rootProject.ext.compileSdkVersion
74+
buildToolsVersion rootProject.ext.buildToolsVersion
75+
compileSdk rootProject.ext.compileSdkVersion
9576

9677
namespace "com.artificialchat"
9778
defaultConfig {
@@ -101,15 +82,6 @@ android {
10182
versionCode 1
10283
versionName "1.0"
10384
}
104-
105-
splits {
106-
abi {
107-
reset()
108-
enable enableSeparateBuildPerCPUArchitecture
109-
universalApk false // If true, also generate a universal APK
110-
include (*reactNativeArchitectures())
111-
}
112-
}
11385
signingConfigs {
11486
debug {
11587
storeFile file('debug.keystore')
@@ -130,36 +102,12 @@ android {
130102
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
131103
}
132104
}
133-
134-
// applicationVariants are e.g. debug, release
135-
applicationVariants.all { variant ->
136-
variant.outputs.each { output ->
137-
// For each separate APK per architecture, set a unique version code as described here:
138-
// https://developer.android.com/studio/build/configure-apk-splits.html
139-
// Example: versionCode 1 will generate 1001 for armeabi-v7a, 1002 for x86, etc.
140-
def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
141-
def abi = output.getFilter(OutputFile.ABI)
142-
if (abi != null) { // null for the universal-debug, universal-release variants
143-
output.versionCodeOverride =
144-
defaultConfig.versionCode * 1000 + versionCodes.get(abi)
145-
}
146-
147-
}
148-
}
149105
}
150106

151107
dependencies {
152108
// The version of react-native is set by the React Native Gradle Plugin
153109
implementation("com.facebook.react:react-android")
154110

155-
implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.0.0")
156-
157-
debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}")
158-
debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") {
159-
exclude group:'com.squareup.okhttp3', module:'okhttp'
160-
}
161-
162-
debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}")
163111
if (hermesEnabled.toBoolean()) {
164112
implementation("com.facebook.react:hermes-android")
165113
} else {

android/app/src/debug/AndroidManifest.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,8 @@
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools">
44

5-
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
6-
75
<application
86
android:usesCleartextTraffic="true"
97
tools:targetApi="28"
10-
tools:ignore="GoogleAppIndexingWarning">
11-
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
12-
</application>
8+
tools:ignore="GoogleAppIndexingWarning"/>
139
</manifest>

0 commit comments

Comments
 (0)