Minor: Move declaration of variable to avoid doubt on previous existence.

ywarnier · ywarnier · commit 07bb31df3327 · 2025-02-07T11:37:37.000+01:00
diff --git a/main/inc/lib/extra_field_value.lib.php b/main/inc/lib/extra_field_value.lib.php
@@ -968,7 +968,7 @@ public function getAllValuesByItemAndField($itemId, $fieldId)
      *
      * @return array
      */
-    public function getAllValuesByItem($itemId)
+    public function getAllValuesByItem(int $itemId): array
     {
         $itemId = (int) $itemId;
         $extraFieldType = $this->getExtraField()->getExtraFieldType();
@@ -984,9 +984,9 @@ public function getAllValuesByItem($itemId)
 
         $result = Database::query($sql);
         $idList = [];
+        $finalResult = [];
         if (Database::num_rows($result)) {
             $result = Database::store_result($result, 'ASSOC');
-            $finalResult = [];
             foreach ($result as $item) {
                 $finalResult[$item['id']] = $item;
             }

Original file line number	Diff line number	Diff line change
`@@ -968,7 +968,7 @@ public function getAllValuesByItemAndField($itemId, $fieldId)`
`968`	`968`	`*`
`969`	`969`	`* @return array`
`970`	`970`	`*/`
`971`		`- public function getAllValuesByItem($itemId)`
	`971`	`+ public function getAllValuesByItem(int $itemId): array`
`972`	`972`	`{`
`973`	`973`	`$itemId = (int) $itemId;`
`974`	`974`	`$extraFieldType = $this->getExtraField()->getExtraFieldType();`
`@@ -984,9 +984,9 @@ public function getAllValuesByItem($itemId)`
`984`	`984`
`985`	`985`	`$result = Database::query($sql);`
`986`	`986`	`$idList = [];`
	`987`	`+ $finalResult = [];`
`987`	`988`	`if (Database::num_rows($result)) {`
`988`	`989`	`$result = Database::store_result($result, 'ASSOC');`
`989`		`- $finalResult = [];`
`990`	`990`	`foreach ($result as $item) {`
`991`	`991`	`$finalResult[$item['id']] = $item;`
`992`	`992`	`}`