-
Notifications
You must be signed in to change notification settings - Fork 27
PgBackrest Dashboard and alert rules #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
32b22f2
feat: enable `pgbackrest_exporter` by default
Deezzir 9a83914
feat: `pgbackrest` Grafana dashboard
Deezzir e2ecc3e
feat: `pgbackrest` alert rules
Deezzir 9e31351
chore: enable `instance` label for some `postgresql` alerts
Deezzir 8aedc2d
chore: add alert rules unit tests
Deezzir 4462a03
docs: update alert rules list
Deezzir 89b4c53
fix: path for alerts in `alert-test` ci job
Deezzir 6bd8396
fix: `test_charm` unit test
Deezzir db8f13a
chore: correct pgbackrest name
Deezzir ea9a459
test: fix `test_restart`
Deezzir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,20 @@ jobs: | |
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| alert-test: | ||
| name: Test Prometheus Alert Rules | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v5 | ||
| - name: Install prometheus snap | ||
| run: sudo snap install prometheus | ||
| - name: Check validity of prometheus alert rules | ||
| run: promtool check rules src/prometheus_alert_rules/* | ||
| - name: Run unit tests for prometheus alert rules | ||
| run: promtool test rules tests/alerts/*.yaml | ||
|
|
||
| build: | ||
| name: Build charm | ||
| uses: canonical/data-platform-workflows/.github/workflows/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use
/start-pgbackrest-exporter.shat the moment because the current script is not prepared to be run in a non-snapped environment, reference, like it is done forstart-exporter.shscript.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. Could you create an issue in the repo for us to address this later? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
canonical/charmed-postgresql-snap#169