Merge pull request #125 from anthonyprintup/fix-124

mrexodia · web-flow · commit 56da4144ae63 · 2023-09-22T16:12:20.000+02:00
fix(generator): Prevent calling `std::string::back` on an empty string
diff --git a/src/cmake_generator.cpp b/src/cmake_generator.cpp
@@ -493,7 +493,7 @@ struct Generator {
                 throw std::runtime_error("Detected additional \" at the end of cmake block");
             }
             auto cmake_lf = tolf(cmake);
-            while (cmake_lf.back() == '\n')
+            while (!cmake_lf.empty() && cmake_lf.back() == '\n')
                 cmake_lf.pop_back();
             bool did_indent = false;
             for (char ch : cmake_lf) {

Original file line number	Diff line number	Diff line change
`@@ -493,7 +493,7 @@ struct Generator {`
`493`	`493`	`throw std::runtime_error("Detected additional \" at the end of cmake block");`
`494`	`494`	`}`
`495`	`495`	`auto cmake_lf = tolf(cmake);`
`496`		`- while (cmake_lf.back() == '\n')`
	`496`	`+ while (!cmake_lf.empty() && cmake_lf.back() == '\n')`
`497`	`497`	`cmake_lf.pop_back();`
`498`	`498`	`bool did_indent = false;`
`499`	`499`	`for (char ch : cmake_lf) {`