Skip to content

Commit c55ae45

Browse files
committed
update test
1 parent 582998a commit c55ae45

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

evals/deterministic/tests/BrowserContext/multiPage.test.ts

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -128,26 +128,24 @@ test.describe("StagehandContext - Multi-page Support", () => {
128128
* Test popup handling
129129
*/
130130
test("should handle popups with enhanced capabilities", async () => {
131-
const mainPage = stagehand.page;
132-
let popupPage: Page | null = null;
131+
await stagehand.page.goto(`http://localhost:${serverPort}/page1`);
132+
await stagehand.page.click("#popupBtn");
133133

134-
mainPage.on("popup", (page: Page) => {
135-
popupPage = page;
136-
});
134+
await expect.poll(() => stagehand.context.pages().length).toBe(2);
137135

138-
await mainPage.goto(`http://localhost:${serverPort}/page1`);
139-
await mainPage.click("#popupBtn");
136+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
137+
const [_original, popupPage] = stagehand.context.pages();
140138

141-
// Verify popup has enhanced capabilities
142-
expect(popupPage).not.toBeNull();
143-
expect(typeof popupPage.act).toBe("function");
144-
expect(typeof popupPage.extract).toBe("function");
145-
expect(typeof popupPage.observe).toBe("function");
139+
await popupPage.waitForLoadState();
146140

147-
if (popupPage) {
148-
await popupPage.waitForLoadState();
149-
expect(await popupPage.title()).toBe("Page 2");
150-
}
141+
const get = (k: string) =>
142+
(popupPage as unknown as Record<string, unknown>)[k];
143+
144+
expect(typeof get("act")).toBe("function");
145+
expect(typeof get("extract")).toBe("function");
146+
expect(typeof get("observe")).toBe("function");
147+
148+
expect(await popupPage.title()).toBe("Page 2");
151149
});
152150

153151
/**

0 commit comments

Comments
 (0)