Remove refreshPageFromApi (#925)

# why
No longer necessary

# what changed
Removed `_refreshPageFromApi` that would get called after each api call,
also fixed `heal_custom_dropdown` eval

# test plan

Author: miguelg719

.changeset/gold-gifts-marry.md

@@ -0,0 +1,5 @@
+---
+"@browserbasehq/stagehand": patch
+---
+
+Remove \_refreshPageFromApi()

evals/deterministic/tests/page/livePageProxy.test.ts

@@ -8,13 +8,16 @@ test.describe("StagehandPage - live page proxy", () => {
     await stagehand.init();
 
     const page = stagehand.page;
-    await page.goto("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/");
+    await page.goto(
+      "https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/",
+    );
     await page.locator("body > button").click();
-    await new Promise(resolve => setTimeout(resolve, 1000));
-    await page.waitForURL('**/page2.html', {waitUntil: "commit"});
+    await new Promise((resolve) => setTimeout(resolve, 1000));
+    await page.waitForURL("**/page2.html", { waitUntil: "commit" });
     // await new Promise(resolve => setTimeout(resolve, 1000));
     const currentURL = page.url();
-    const expectedURL = "https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html";
+    const expectedURL =
+      "https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html";
 
     expect(currentURL).toBe(expectedURL);
 
@@ -26,9 +29,11 @@ test.describe("StagehandPage - live page proxy", () => {
     await stagehand.init();
 
     const page = stagehand.page;
-    await page.goto("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/");
+    await page.goto(
+      "https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/",
+    );
     await page.locator("body > button").click();
-    await new Promise(resolve => setTimeout(resolve, 1000));
+    await new Promise((resolve) => setTimeout(resolve, 1000));
 
     const expectedNumPages = 2;
     const actualNumPages = stagehand.context.pages().length;

evals/tasks/heal_custom_dropdown.ts

@@ -22,7 +22,7 @@ export const heal_custom_dropdown: EvalFunction = async ({
     );
 
     await page.act({
-      description: "The dropdown",
+      description: "The 'Select a country' dropdown",
       selector: "/html/not-a-dropdown",
       arguments: [],
       method: "click",

lib/StagehandPage.ts

@@ -1,6 +1,4 @@
-import { Browserbase } from "@browserbasehq/sdk";
 import type { CDPSession, Page as PlaywrightPage, Frame } from "playwright";
-import { chromium } from "playwright";
 import { z } from "zod";
 import { Page, defaultExtractSchema } from "../types/page";
 import {
@@ -23,7 +21,6 @@ import {
   StagehandNotInitializedError,
   StagehandEnvironmentError,
   CaptchaTimeoutError,
-  BrowserbaseSessionNotFoundError,
   MissingLLMConfigurationError,
   HandlerNotInitializedError,
   StagehandDefaultError,
@@ -191,40 +188,6 @@ ${scriptContent} \
     }
   }
 
-  private async _refreshPageFromAPI() {
-    if (!this.api) return;
-
-    const sessionId = this.stagehand.browserbaseSessionID;
-    if (!sessionId) {
-      throw new BrowserbaseSessionNotFoundError();
-    }
-
-    const browserbase = new Browserbase({
-      apiKey: this.stagehand["apiKey"] ?? process.env.BROWSERBASE_API_KEY,
-    });
-
-    const sessionStatus = await browserbase.sessions.retrieve(sessionId);
-
-    const connectUrl = sessionStatus.connectUrl;
-    const browser = await chromium.connectOverCDP(connectUrl);
-    const context = browser.contexts()[0];
-    const newPage = context.pages()[0];
-
-    const newStagehandPage = await new StagehandPage(
-      newPage,
-      this.stagehand,
-      this.intContext,
-      this.llmClient,
-      this.userProvidedInstructions,
-      this.api,
-    ).init();
-
-    this.intPage = newStagehandPage.page;
-
-    await this.intPage.waitForLoadState("domcontentloaded");
-    await this._waitForSettledDom();
-  }
-
   /**
    * Waits for a captcha to be solved when using Browserbase environment.
    *
@@ -387,20 +350,17 @@ ${scriptContent} \
                 }
               }
 
-              if (this.api) {
-                await this._refreshPageFromAPI();
-              } else {
-                if (stagehand.debugDom) {
-                  this.stagehand.log({
-                    category: "deprecation",
-                    message:
-                      "Warning: debugDom is not supported in this version of Stagehand",
-                    level: 1,
-                  });
-                }
-                await target.waitForLoadState("domcontentloaded");
-                await this._waitForSettledDom();
+              if (this.stagehand.debugDom) {
+                this.stagehand.log({
+                  category: "deprecation",
+                  message:
+                    "Warning: debugDom is not supported in this version of Stagehand",
+                  level: 1,
+                });
               }
+              await target.waitForLoadState("domcontentloaded");
+              await this._waitForSettledDom();
+
               return result;
             };
           }
@@ -655,7 +615,6 @@ ${scriptContent} \
               ...observeResult,
               frameId: this.rootFrameId,
             });
-            await this._refreshPageFromAPI();
             this.stagehand.addToHistory("act", observeResult, result);
             return result;
           }
@@ -688,7 +647,6 @@ ${scriptContent} \
       if (this.api) {
         const opts = { ...actionOrOptions, frameId: this.rootFrameId };
         const result = await this.api.act(opts);
-        await this._refreshPageFromAPI();
         this.stagehand.addToHistory("act", actionOrOptions, result);
         return result;
       }

lib/index.ts

@@ -616,8 +616,7 @@ export class Stagehand {
       this.llmClient = llmClient;
       this.logger({
         category: "init",
-        message:
-          "Custom LLM clients are currently not supported in API mode",
+        message: "Custom LLM clients are currently not supported in API mode",
         level: 1,
       });
       this.usingAPI = false;