chore(eth-bytecode-db): fix clippy warnings (#1429)

Author: rimrakhimov

eth-bytecode-db/eth-bytecode-db-server/src/services/verifier_base.rs

@@ -42,7 +42,7 @@ pub fn process_batch_import_error(error: Error) -> tonic::Status {
         }
         Error::Verifier(message) => {
             tracing::error!(details=%message, "Internal verifier error");
-            tonic::Status::internal(format!("Verifier error: {}", message))
+            tonic::Status::internal(format!("Verifier error: {message}"))
         }
         err => {
             tracing::error!("Unexpected error");

eth-bytecode-db/eth-bytecode-db/src/verification/handlers/mod.rs

@@ -134,8 +134,8 @@ impl<'a> VerifierAllianceDbAction<'a> {
                 }),
             ) => {
                 // Contract deployment must have runtime code to exist (it may be empty, though)
-                if is_authorized && runtime_code.is_some() {
-                    Self::SaveWithDeploymentData {
+                match runtime_code {
+                    Some(runtime_code) if is_authorized => Self::SaveWithDeploymentData {
                         db_client,
                         deployment_data: AllianceContract {
                             chain_id: format!("{chain_id}"),
@@ -145,17 +145,16 @@ impl<'a> VerifierAllianceDbAction<'a> {
                             transaction_index,
                             deployer,
                             creation_code,
-                            runtime_code: runtime_code.unwrap(),
+                            runtime_code,
                         },
-                    }
-                } else {
-                    Self::SaveIfDeploymentExists {
+                    },
+                    _ => Self::SaveIfDeploymentExists {
                         db_client,
                         chain_id,
                         contract_address,
                         transaction_hash,
                         runtime_code,
-                    }
+                    },
                 }
             }
             _ => Self::IgnoreDb,

eth-bytecode-db/eth-bytecode-db/src/verification/types.rs

@@ -500,7 +500,7 @@ pub struct VerificationMetadata {
 
 impl From<VerificationMetadata> for smart_contract_verifier::VerificationMetadata {
     fn from(value: VerificationMetadata) -> Self {
-        let chain_id = value.chain_id.map(|id| format!("{}", id));
+        let chain_id = value.chain_id.map(|id| format!("{id}"));
         let contract_address = value
             .contract_address
             .map(|address| blockscout_display_bytes::Bytes::from(address).to_string());

eth-bytecode-db/verifier-alliance-database-tests/src/test_case.rs

@@ -207,7 +207,7 @@ impl TestCase {
             .one(database_connection)
             .await
             .expect("error while retrieving code value")
-            .unwrap_or_else(|| panic!("code hash does not exist in the database: {:?}", code_hash));
+            .unwrap_or_else(|| panic!("code hash does not exist in the database: {code_hash:?}"));
 
         let expected_code_hash_keccak = Keccak256::digest(&code).to_vec();
         assert_eq!(

eth-bytecode-db/verifier-alliance-database/tests/integration/verified_contracts.rs

@@ -281,8 +281,7 @@ async fn not_override_partial_matches() {
     .map_err(|err| {
         assert!(
             err.to_string().contains("is not better than existing"),
-            "unexpected error: {}",
-            err
+            "unexpected error: {err}"
         )
     })
     .expect_err("error expected while inserting another partially verified contract");