Skip to content

Commit cd95672

Browse files
xypronJeff Kirsher
authored andcommitted
i40e: avoid null pointer dereference
In function i40e_debug_aq parameter desc is assumed to be possibly NULL. Do not dereference it before checking the value. Fixes: f905dd6 ("i40e/i40evf: add max buf len to aq debug print helper") Signed-off-by: Heinrich Schuchardt <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent d95a93a commit cd95672

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/net/ethernet/intel/i40e/i40e_common.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,13 +297,15 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,
297297
void *buffer, u16 buf_len)
298298
{
299299
struct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;
300-
u16 len = le16_to_cpu(aq_desc->datalen);
300+
u16 len;
301301
u8 *buf = (u8 *)buffer;
302302
u16 i = 0;
303303

304304
if ((!(mask & hw->debug_mask)) || (desc == NULL))
305305
return;
306306

307+
len = le16_to_cpu(aq_desc->datalen);
308+
307309
i40e_debug(hw, mask,
308310
"AQ CMD: opcode 0x%04X, flags 0x%04X, datalen 0x%04X, retval 0x%04X\n",
309311
le16_to_cpu(aq_desc->opcode),

0 commit comments

Comments
 (0)