Jasper-564(DARS) #610
Open
Jasper-564(DARS) #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [eslint](https://github.com/eslint/eslint) from 9.37.0 to 9.38.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.37.0...v9.38.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.38.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
WadeBarnes
approved these changes
Oct 30, 2025
| } | ||
|
|
||
| public static IServiceCollection AddHttpClientsAndScvServices(this IServiceCollection services, IConfiguration configuration) | ||
| public static IServiceCollection AddHttpClientsAndScvServices(this IServiceCollection services, IConfiguration configuration, IWebHostEnvironment env) |
There was a problem hiding this comment.
is the new env param really needed? i don't seem to see it being used.
| [ProducesResponseType(400)] | ||
| [ProducesResponseType(404)] | ||
| [ProducesResponseType(500)] | ||
| public async Task<IActionResult> Search(DateTime date, int locationId, string courtRoomCd) |
There was a problem hiding this comment.
Do we also need validation for date and courtRoomCd?
|
|
||
| namespace Scv.Api.Services | ||
| { | ||
| public class DarsService |
There was a problem hiding this comment.
May want to consider adding an interface so unit testing is easier particularly on new classes.
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
There was a problem hiding this comment.
Should remove the warnings when this code is added.
Suggested change
| #pragma warning disable 8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable. |
|
|
||
| public string LocationNm { get; set; } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| #pragma warning restore 8618 | |
| } |
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace DARSCommon.Models |
There was a problem hiding this comment.
nit: There is a an internal agreement that file-scope namespace is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for JIRA Ticket: ----put ticket number here----
Issue ticket number and link
Include the JIRA ticket # and link here
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
-Test Dars search, as well as headphone link in appearances, court calendar and my calendar (expanded).
-Validate that outgoing DARS url to logsheets matches PCSS.
Checklist:
Documentation References
Put any doc references here