Skip to content

Commit 2b0669a

Browse files
committed
Switch to use ZstdDictionaries
1 parent 1a9b2d8 commit 2b0669a

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

build/bazel/remote/execution/v2/remote_execution.proto

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2002,23 +2002,29 @@ message Compressor {
20022002
//
20032003
// When this is used, the server MUST advertise the dictionaries by
20042004
// including
2005-
// [ZstdDictionaryRegistry][build.bazel.remote.execution.v2.ZstdDictionaryRegistry]
2005+
// [ZstdDictionaries][build.bazel.remote.execution.v2.ZstdDictionaries]
20062006
// digest in CacheCapabilities.
20072007
ZSTD_DICT = 4;
20082008
}
20092009
}
20102010

2011-
message ZstdDictionaryRegistry {
2012-
// Each file respresent a single Zstandard dictionary
2013-
// with name being the `dictId` that was added to the header
2014-
// of the compressed file.
2015-
//
2016-
// A special file with name `default` is used to represent the
2017-
// default dictionary that is used when no `dictId` is specified.
2018-
// Clients SHOULD prefer to use the default dictionary when possible.
2019-
//
2020-
// The `default` dictionary MUST be present.
2021-
repeated FileNode dictionaries = 1;
2011+
message ZstdDictionaries {
2012+
message Dictionary {
2013+
uint32 id 1;
2014+
Digest digest 2;
2015+
}
2016+
2017+
// The dictionary ID that clients SHOULD use when uploading
2018+
// objects into the Content Addressable Storage. An entry for
2019+
// this dictionary ID MUST be present in `dictionaries`.
2020+
uint32 default_dictionary_id = 1;
2021+
2022+
// Dictionaries that may be used by the server when returning
2023+
// objects stored in the Content Addressable Storage. The key
2024+
// corresponds to a dictionary ID, as described in RFC 8878,
2025+
// section 5, while the value refers to a dictionary
2026+
// as described in RFC 8878, chapter 6.
2027+
repeated Dictionary dictionaries = 2;
20222028
}
20232029

20242030
// Capabilities of the remote cache system.
@@ -2056,9 +2062,9 @@ message CacheCapabilities {
20562062
repeated Compressor.Value supported_batch_update_compressors = 7;
20572063

20582064
// The digest of the
2059-
// [ZstdDictionaryRegistry][build.bazel.remote.execution.v2.ZstdDictionaryRegistry]
2065+
// [ZstdDictionaries][build.bazel.remote.execution.v2.ZstdDictionaries]
20602066
// that contains all the dictionaries supported by the remote cache.
2061-
Digest zstd_dictionary_registry = 8;
2067+
Digest zstd_dictionaries = 8;
20622068
}
20632069

20642070
// Capabilities of the remote execution system.

0 commit comments

Comments
 (0)