Pin @radix-ui/react-slot dependency to SemVer MAJOR
#111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 249a647 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@eps1lon is attempting to deploy a commit to the BaseHub Team on Vercel. A member of the Team first needs to authorize it. |
Pinning it to its patch version contributes to dependency duplication in applications using `basehub` and `@radix-ui/react-slot`. The package is not known for violating SemVer so pinning the version to its major is safe. This ensures fixes are propagated faster throughout the ecosystem. In this case, `@radix-ui/slot` published a fix for React 19 compat that `basehub` users won't get until a new `basehub` release is out. It helps us in the React team in gathering feedback quicker since we don't need to ensure each dependent updates its dependencies even when their dependencies can ensure compatibility with a SemVer MINOR.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning it to its patch version contributes to dependency duplication in applications using
basehuband@radix-ui/react-slot.@radix-ui/react-slotis not known for violating SemVer so pinning the version to its major is safe.This ensures fixes are propagated faster throughout the ecosystem. In this case,
@radix-ui/slotpublished a fix for React 19 compat thatbasehubusers won't get until a newbasehubrelease is out. It helps us in the React team in gathering feedback quicker since we don't need to ensure each dependent updates its dependencies even when their dependencies can ensure compatibility with a SemVer MINOR.