Skip to content

Conversation

@radko93
Copy link
Contributor

@radko93 radko93 commented Sep 3, 2024

When running a project with RN 0.75 following is printed:

[Codegen] Found @bam.tech/react-native-image-resizer
[Codegen] CodegenConfig Deprecated Setup for @bam.tech/react-native-image-resizer.
    The configuration file still contains the codegen in the libraries array.
    If possible, replace it with a single object.
  
BEFORE:
    {
      // ...
      "codegenConfig": {
        "libraries": [
          {
            "name": "libName1",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName1/js"
          },
          {
            "name": "libName2",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName2/src"
          }
        ]
      }
    }

    AFTER:
    {
      "codegenConfig": {
        "name": "libraries",
        "type": "all",
        "jsSrcsRoot": "."
      }
    }
    ```

@radko93 radko93 changed the title feat: update codegen config fix: update codegen config Sep 3, 2024
@ravindraguptacapgemini
Copy link

when I can expect this PR to get merged?

@ravindraguptacapgemini
Copy link

ravindraguptacapgemini commented Oct 25, 2024

please include this change as well in your PR, iOS build failure due to this on React Native 0.75

diff --git a/react-native-image-resizer.podspec b/react-native-image-resizer.podspec
index c7ba7d9e261abbb890cccf0c9dd58eba118083be..749803239f7765994408d525e3cf7cff787e847a 100644
--- a/react-native-image-resizer.podspec
+++ b/react-native-image-resizer.podspec
@@ -32,6 +32,7 @@ Pod::Spec.new do |s|
s.dependency "RCTRequired"
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"

  • install_modules_dependencies(s)
    end
    end

@ravindraguptacapgemini
Copy link

ravindraguptacapgemini commented Nov 13, 2024

@radko93 can you please include the podspec change as well as part of this PR. @gustavomts @alexkev

@macksal
Copy link

macksal commented Nov 20, 2024

@ravindraguptacapgemini you might get better traction opening that as a separate PR and request it to be merged ASAP

@radko93
Copy link
Contributor Author

radko93 commented Nov 20, 2024

@ravindraguptacapgemini @macksal I've added the pod spec change, it should work for both and old arch.

@ravindraguptacapgemini
Copy link

Thank you @radko93 , when can I expect a new version release with these changes?

@macksal
Copy link

macksal commented Nov 25, 2024

paging @gustavomts @alexkev for review and release. Please check it when possible, this is a blocker for users migrating to new architecture 🤞🏼

edit: whoops, meant @taboulot

@Almouro
Copy link
Contributor

Almouro commented Nov 25, 2024

Hi @radko93, thanks so much for raising this pull request and your patience! ♥️

This all seems very sensible! Do you know if those changes are breaking for previous RN versions?

@radko93
Copy link
Contributor Author

radko93 commented Nov 25, 2024

@Almouro it's compatible with both, similar to https://github.com/react-native-google-signin/google-signin/blob/a7df8bb0ba6a6fd18ed00170fb286a84b4080b2d/RNGoogleSignin.podspec#L21

@Almouro Almouro merged commit 36ef1a9 into bamlab:master Nov 25, 2024
@Almouro
Copy link
Contributor

Almouro commented Nov 25, 2024

Thanks @radko93 ! 🙏
It is now published as 3.0.11 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants