Skip to content

Conversation

@OHHAKO
Copy link
Contributor

@OHHAKO OHHAKO commented Oct 26, 2023

Hello. Thanks for maintaining this repo.

I just added namespace only for AOS. #390
i don't know there is PR template here. check please
this PR related to react-native-community/discussions-and-proposals#671

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more proper fix would be like this:

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
    namespace "com.reactnativeimageresizer"
}

@ahinkle
Copy link

ahinkle commented Dec 17, 2023

Any movement on this one? I would hate to abandon/main a fork of this package for such a simple thing.

@gh-clement-taboulot
Copy link
Contributor

@OHHAKO Thx for the PR.
We will find someone next week at BAM to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants