test(getstepdefinitionspaths): tweaked tests, use path.resolve for commonPath

fix #275

Author: lgandecki

lib/getStepDefinitionsPaths.js

@@ -1,3 +1,4 @@
+const path = require("path");
 const glob = require("glob");
 const { getConfig } = require("./getConfig");
 const stepDefinitionPath = require("./stepDefinitionPath.js");
@@ -15,7 +16,7 @@ const getStepDefinitionsPaths = filePath => {
     let commonPath = config.commonPath || `${stepDefinitionPath()}/common/`;
 
     if (config.commonPath) {
-      commonPath = `${appRoot}/${commonPath}`;
+      commonPath = path.resolve(appRoot, commonPath);
     }
     const commonDefinitionsPattern = `${commonPath}**/*.+(js|ts)`;
     paths = paths.concat(glob.sync(nonGlobalPattern));

lib/getStepDefinitionsPaths.test.js

@@ -1,21 +1,24 @@
+/* eslint-disable global-require */
 jest.mock("./stepDefinitionPath.js", () => () => "stepDefinitionPath");
 jest.mock("glob", () => ({
   sync(pattern) {
     return pattern;
   }
 }));
 
+let getConfig;
+
 describe("getStepDefinitionsPaths", () => {
-  it("should return the default common folder", () => {
+  beforeEach(() => {
     jest.resetModules();
-    jest.mock("cosmiconfig", () => () => ({
-      load: () => ({
-        config: {
-          nonGlobalStepDefinitions: true
-        }
-      })
-    }));
-    // eslint-disable-next-line global-require
+    ({ getConfig } = require("./getConfig"));
+    jest.mock("./getConfig");
+  });
+  it("should return the default common folder", () => {
+    getConfig.mockReturnValue({
+      nonGlobalStepDefinitions: true
+    });
+
     const { getStepDefinitionsPaths } = require("./getStepDefinitionsPaths");
 
     const actual = getStepDefinitionsPaths("/path");
@@ -24,26 +27,28 @@ describe("getStepDefinitionsPaths", () => {
     expect(actual).to.include(expected);
   });
 
-  it("should return the common folder defined by the developper", () => {
-    jest.resetModules();
+  it("should return the common folder defined by the developer", () => {
+    jest.mock("path", () => ({
+      resolve(appRoot, commonPath) {
+        return `./${appRoot}/${commonPath}`;
+      },
+      extname() {
+        return ".js";
+      }
+    }));
 
     jest.mock("fs");
     jest.spyOn(process, "cwd").mockImplementation(() => "cwd");
 
-    jest.mock("cosmiconfig", () => () => ({
-      load: () => ({
-        config: {
-          nonGlobalStepDefinitions: true,
-          commonPath: "myPath/"
-        }
-      })
-    }));
-    // eslint-disable-next-line global-require
+    getConfig.mockReturnValue({
+      nonGlobalStepDefinitions: true,
+      commonPath: "myPath/"
+    });
+
     const { getStepDefinitionsPaths } = require("./getStepDefinitionsPaths");
 
     const actual = getStepDefinitionsPaths("/path");
-    const expected = "cwd/myPath/**/*.+(js|ts)";
-
+    const expected = "./cwd/myPath/**/*.+(js|ts)";
     expect(actual).to.include(expected);
   });
 });