Add node affinity to kit substrate components #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-zhe-huang
requested review from
ellistarn,
hakuna-matatah,
natherz97 and
prateekgogia
as code owners
felix-zhe-huang
commented
Apr 7, 2022
substrate/pkg/controller/substrate/cluster/addons/kitoperator.go
Outdated
Show resolved
Hide resolved
felix-zhe-huang
commented
Apr 7, 2022
prateekgogia
suggested changes
Apr 8, 2022
Contributor
prateekgogia
left a comment
prateekgogia
left a comment
There was a problem hiding this comment.
I think we also need nodeSelectors for Karpenter, EBS CSI driver, AWS LB
substrate/pkg/controller/substrate/cluster/addons/kitoperator.go
Outdated
Show resolved
Hide resolved
ellistarn
reviewed
Apr 8, 2022
ellistarn
reviewed
Apr 8, 2022
ellistarn
reviewed
Apr 8, 2022
substrate/pkg/controller/substrate/cluster/addons/tekton-dashboard.go
Outdated
Show resolved
Hide resolved
felix-zhe-huang
force-pushed
the
node_taint
branch
from
75cca94 to
38a7650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#108
Description of changes:
Add node affinity to kit operator, prometheus, and tekton.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.