ci: fix clippy test (#2686)

Author: CarolYeh910

dc/s2n-quic-dc/src/path/secret/map/state/tests.rs

@@ -192,12 +192,12 @@ impl Model {
             match invariant {
                 Invariant::ContainsIp(ip) => {
                     if state.max_capacity != 5 {
-                        assert!(state.peers.contains_key(ip), "{:?}", ip);
+                        assert!(state.peers.contains_key(ip), "{ip:?}");
                     }
                 }
                 Invariant::ContainsId(id) => {
                     if state.max_capacity != 5 {
-                        assert!(state.ids.contains_key(id), "{:?}", id);
+                        assert!(state.ids.contains_key(id), "{id:?}");
                     }
                 }
                 Invariant::IdRemoved(id) => {

dc/s2n-quic-dc/src/stream/client/rpc.rs

@@ -27,7 +27,7 @@ where
     reader.set_read_mode(ReadMode::UntilFull);
 
     // TODO if the request is large enough, should we spawn a task for it?
-    let mut writer = async move {
+    let writer = async move {
         while !request.buffer_is_empty() {
             writer.write_from_fin(&mut request).await?;
         }
@@ -39,7 +39,7 @@ where
     let mut writer = core::pin::pin!(writer);
     let mut writer_finished = false;
 
-    let mut reader = async move {
+    let reader = async move {
         loop {
             let storage = response.provide_storage().await?;
 

dc/s2n-quic-dc/src/stream/send/flow/blocking.rs

@@ -233,7 +233,7 @@ mod tests {
         let mut at_least_one_write = true;
         for (idx, count) in worker_counts.into_iter().enumerate() {
             let count = count.load(Ordering::Relaxed);
-            eprintln!("thread={idx}, count={}", count);
+            eprintln!("thread={idx}, count={count}");
             if count == 0 {
                 at_least_one_write = false;
             }

dc/s2n-quic-dc/src/stream/send/flow/non_blocking.rs

@@ -308,7 +308,7 @@ mod tests {
         let mut at_least_one_write = true;
         for (idx, count) in worker_counts.into_iter().enumerate() {
             let count = count.load(Ordering::Relaxed);
-            println!("thread={idx}, count={}", count);
+            println!("thread={idx}, count={count}");
             if count == 0 {
                 at_least_one_write = false;
             }

dc/s2n-quic-dc/src/task/waker/set.rs

@@ -47,7 +47,8 @@ impl Set {
     /// Returns all of the IDs that are woken
     #[inline]
     pub fn drain(&mut self) -> impl Iterator<Item = usize> + '_ {
-        core::mem::swap(&mut self.ready, &mut self.state.ready.lock().unwrap());
+        let mut state = self.state.ready.lock().unwrap();
+        core::mem::swap(&mut self.ready, &mut state);
         self.ready.drain()
     }
 }

quic/s2n-quic-core/src/buffer/reassembler/tests.rs

@@ -1066,17 +1066,15 @@ fn allocation_size_test() {
         assert_eq!(
             Reassembler::allocation_size(offset),
             size,
-            "offset = {}",
-            offset
+            "offset = {offset}"
         );
 
         if let Some((offset, _)) = received.get(index + 1) {
             let offset = offset - 1;
             assert_eq!(
                 Reassembler::allocation_size(offset),
                 size,
-                "offset = {}",
-                offset
+                "offset = {offset}"
             );
         }
     }

quic/s2n-quic-core/src/crypto/tls/null.rs

@@ -60,7 +60,7 @@ impl<T> Default for Endpoint<T> {
  ████████████████████████████████████████████████████████████████
  ▓▓████████████████████████████████████████████████████████████▓▓
             ";
-            eprintln!("{}", WARNING);
+            eprintln!("{WARNING}");
             eprintln!();
             eprintln!("                  =====  W A R N I N G !!! =====");
             eprintln!();
@@ -72,7 +72,7 @@ impl<T> Default for Endpoint<T> {
             eprintln!("  integrity, or authenticity.");
             eprintln!();
             let location = core::panic::Location::caller();
-            eprintln!("  Endpoint configured by: {}", location);
+            eprintln!("  Endpoint configured by: {location}");
             eprintln!();
             eprintln!("                  ==============================");
         }

quic/s2n-quic-core/src/frame/crypto.rs

@@ -165,8 +165,7 @@ mod tests {
 
             assert!(
                 frame.encoding_size() <= capacity,
-                "the encoding_size should not exceed capacity {:#?}",
-                frame
+                "the encoding_size should not exceed capacity {frame:#?}"
             );
 
             if new_length < length {
@@ -190,8 +189,7 @@ mod tests {
         } else {
             assert!(
                 frame.encoding_size() > capacity,
-                "rejection should only occur when encoding size > capacity {:#?}",
-                frame
+                "rejection should only occur when encoding size > capacity {frame:#?}"
             );
         }
     }

quic/s2n-quic-core/src/frame/stream.rs

@@ -319,8 +319,7 @@ mod tests {
             // we should never exceed the capacity
             assert!(
                 frame.encoding_size() <= capacity,
-                "the encoding_size should not exceed capacity {:#?}",
-                frame
+                "the encoding_size should not exceed capacity {frame:#?}"
             );
 
             if new_length < length {
@@ -346,15 +345,13 @@ mod tests {
                 assert_eq!(
                     frame.encoding_size(),
                     capacity,
-                    "should only be the last frame if == capacity {:#?}",
-                    frame
+                    "should only be the last frame if == capacity {frame:#?}"
                 );
             }
         } else {
             assert!(
                 frame.encoding_size() > capacity,
-                "rejection should only occur when encoding size > capacity {:#?}",
-                frame
+                "rejection should only occur when encoding size > capacity {frame:#?}"
             );
         }
     }

quic/s2n-quic-core/src/packet/number/map.rs

@@ -724,7 +724,7 @@ mod tests {
                         }
                         (None, None) => break,
                         (actual, expected) => {
-                            panic!("expected: {:?}, actual: {:?}", expected, actual);
+                            panic!("expected: {expected:?}, actual: {actual:?}");
                         }
                     }
                 }