-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(rds): monitoringInterval in DatabaseClusterProps does not work with token
#33516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
monitoringInterval in DatabaseClusterPropsmonitoringInterval in DatabaseClusterProps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33516 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 119 119
Lines 6862 6862
Branches 1158 1158
=======================================
Hits 5639 5639
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Exemption Request This PR changes validations only. |
go-to-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I will approve. But could you please change the PR title to the style: fix(rds): description of the bug in the fix case?
For example: fix(rds): `monitoringInterval` in `DatabaseClusterProps` does not work with token.
monitoringInterval in DatabaseClusterPropsmonitoringInterval in DatabaseClusterProps does not work with token
monitoringInterval in DatabaseClusterProps does not work with tokenmonitoringInterval in DatabaseClusterProps does not work with token
|
Thank you for the fix! I've approved it and let's get this released in next week's release. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33504.
Reason for this change
monitoringIntervalprop inDatabaseClusterPropsshould accept a token.Description of changes
Skip validations if
monitoringIntervalis a token.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added a unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license