Skip to content

chore(s3): update annotation phrase of addReplicationPolicy() #33459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

chore(s3): update annotation phrase of addReplicationPolicy() #33459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c182c41
update annotation
badmintoncryer Feb 14, 2025
98e8523
Merge branch 'main' into fix-annotation
badmintoncryer Feb 17, 2025
8812db6
Merge branch 'main' into fix-annotation
mergify[bot] Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-s3/lib/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2850,7 +2850,7 @@ export class Bucket extends BucketBase {
const isCrossAccount = sourceAccount !== destinationAccount;

if (isCrossAccount) {
Annotations.of(this).addInfo('For Cross-account S3 replication, ensure to set up permissions on source bucket using method addReplicationPolicy() ');
Annotations.of(this).addInfo('For Cross-account S3 replication, ensure to set up permissions on destination bucket using method addReplicationPolicy() ');
} else if (rule.accessControlTransition) {
throw new ValidationError('accessControlTranslation is only supported for cross-account replication', this);
}
Expand Down