Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 14, 2025

The init templates still have a single %cdk-version% placeholder for both the library and the CLI.

Introduce a new %cdk-cli-version% placeholder and fill it with the "current" version of the CLI used to create the template.

Turning DISPLAY_VERSION into a lazy function, because we added a dependency init.ts -> version.ts, and since init.ts is included in a pre-build script, we now include version.ts in that pre-build script which tries to read a file at load time that still needs to be generated.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The init templates still have a single `%cdk-version%` placeholder
for both the library and the CLI.

Introduce a new `%cdk-cli-version%` placeholder and fill it with
the "current" version of the CLI used to create the template.
@rix0rrr rix0rrr requested a review from a team as a code owner February 14, 2025 09:43
@github-actions github-actions bot added the p2 label Feb 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 14, 2025 09:44
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 14, 2025
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (e5e4f9b) to head (441fc04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33449   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14269    14271    +2     
  Branches     2492     2492           
=======================================
+ Hits        11558    11560    +2     
  Misses       2425     2425           
  Partials      286      286           
Flag Coverage Δ
suite.unit 81.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.92% <100.00%> (+<0.01%) ⬆️
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 441fc04
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Feb 14, 2025
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Feb 14, 2025

Tests failed but with the following error, which this PR surely™️ can't have caused:

      npm error code ETARGET
      npm error notarget No matching version found for @babel/generator@^7.26.9.

So I'm confident enough proceeding

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2025 13:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Feb 14, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 523e0f0 into main Feb 14, 2025
39 checks passed
@mergify mergify bot deleted the huijbers/init-template-cli-version branch February 14, 2025 13:25
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants