-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(cli): init templates still assume the same versions #33449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The init templates still have a single `%cdk-version%` placeholder for both the library and the CLI. Introduce a new `%cdk-cli-version%` placeholder and fill it with the "current" version of the CLI used to create the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33449 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 238 238
Lines 14269 14271 +2
Branches 2492 2492
=======================================
+ Hits 11558 11560 +2
Misses 2425 2425
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Tests failed but with the following error, which this PR surely™️ can't have caused: So I'm confident enough proceeding |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The init templates still have a single
%cdk-version%placeholder for both the library and the CLI.Introduce a new
%cdk-cli-version%placeholder and fill it with the "current" version of the CLI used to create the template.Turning
DISPLAY_VERSIONinto a lazy function, because we added a dependencyinit.ts -> version.ts, and sinceinit.tsis included in a pre-build script, we now includeversion.tsin that pre-build script which tries to read a file at load time that still needs to be generated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license