Skip to content

Conversation

@godwingrs22
Copy link
Member

@godwingrs22 godwingrs22 commented Feb 11, 2025

Issue # (if applicable)

Closes N/A

Reason for this change

The existing PR's in the prioritization board with updated status such as In Progress, Assigned is automatically reset to the Ready status when the github action workflow is triggered for the same PR.

Description of changes

In this PR, made changes to check if a PR is already in the board first and if it is then we maintain the existing status and won't update the status. If the PR is new, then it will be added to board and also the status will be set to Ready.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

  • Update unit tests
  • Ran locally in test repo

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 22:21
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 11, 2025
@godwingrs22 godwingrs22 marked this pull request as ready for review February 11, 2025 22:31
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (a7d7373) to head (b992ebb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33402   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         236      236           
  Lines       14255    14255           
  Branches     2491     2491           
=======================================
  Hits        11536    11536           
  Misses       2434     2434           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b992ebb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 19e603b into aws:main Feb 11, 2025
38 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants