Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 4, 2025

Reason for this change

After removing emojis and ANSI colors, an IoMessage might end up with floating whitespace at either end. We want to trim this whitespace.

Description of changes

Always trim whitespace from IoMessages.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 4, 2025 11:26
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (9a0e1ad) to head (ae2a168).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33284   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         236      236           
  Lines       14235    14235           
  Branches     2487     2487           
=======================================
  Hits        11503    11503           
  Misses       2448     2448           
  Partials      284      284           
Flag Coverage Δ
suite.unit 80.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.14% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ae2a168
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5e35788 into main Feb 4, 2025
20 checks passed
@mergify mergify bot deleted the mrgrain/chore/toolkit/trim-whitespace branch February 4, 2025 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants