Skip to content

Conversation

@maramure
Copy link
Contributor

@maramure maramure commented Sep 5, 2025

Issue # (if applicable)

Closes #.

Reason for this change

AWS CDK currently lacks L2 constructs for Serverless ElastiCache and user management features. Customers must work directly with L1 constructs (CfnUser, CfnUserGroup, CfnServerlessCache) which are verbose and lack the convenience, validation, and best practices that L2 constructs provide.

Description of changes

This PR implements the L2 constructs for ElastiCache UserGroup and ServerlessCache as an initial step towards complete Serverless ElastiCache support.

Files added to aws-elasticache package:

  • common.ts - Shared UserEngine enum (VALKEY, REDIS)
  • user-group.ts - Complete UserGroup L2 construct with import methods, addUser() functionality, and engine-specific validation
  • serverless-cache-base.ts - Engine Enum; Interface and Base class for ServerlessCache L2 construct
  • serverless-cache.ts - Complete ServerlessCache L2 construct with IAM grant methods, comprehensive CloudWatch metrics, networking connections, backup management, usage limits configuration, and robust input validations
  • user-base.ts - Base class and interface extended by ElastiCache User constructs with shared properties and import methods
  • password-user.ts- Complete PasswordUser L2 construct with password-based authentication, and proper validations
  • no-password-user.ts- Complete NoPasswordUser L2 construct without password authentication, and proper validations
  • iam-user.ts - Complete IamUser L2 construct with IAM authentication, connect permissions, and validations
  • README.md - Complete user manual describing how to create and configure a user, user group and a serverless cache, explaining all the important features

Describe any new or updated permissions being added

NA

Description of how you validated changes

I implemented unit tests for all the construct files introduced: all the 3 types of users, user-group and serverless-cache.
I also added integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 5, 2025 15:36
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 5, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@gasolima gasolima added the pr/do-not-merge This PR should not be merged at this time. label Sep 8, 2025
@maramure maramure force-pushed the elasticache branch 2 times, most recently from 0146d26 to 06537ee Compare September 10, 2025 14:35
Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few inline comments

Copy link
Contributor

@gasolima gasolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module needs to ends with -alpha see examples here

Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I've added some comments, though I haven't completed the full review yet."

@mergify mergify bot mentioned this pull request Sep 18, 2025
1 task
@maramure maramure force-pushed the elasticache branch 2 times, most recently from 6632657 to 847097e Compare September 23, 2025 08:14
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 23, 2025 08:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 23, 2025 08:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed gasolima’s stale review September 23, 2025 08:26

Pull request has been modified.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 23, 2025 12:23

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

kumvprat
kumvprat previously approved these changes Sep 26, 2025
Copy link
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumvprat kumvprat removed the pr/do-not-merge This PR should not be merged at this time. label Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot removed the queued label Sep 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35424 has been dequeued. Mergify failed to merge the pull request. GitHub can't merge the pull request after 15 retries.
Waiting for the branch protection required status checks to be validated.

You can check the last failing draft PR here: #35605.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kumvprat’s stale review September 29, 2025 08:16

Pull request has been modified.

@ozelalisen
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot added the queued label Sep 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0e08c8c into aws:main Sep 29, 2025
27 of 28 checks passed
@mergify mergify bot removed the queued label Sep 29, 2025
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants