Skip to content

Conversation

@frankhefeng
Copy link
Contributor

@frankhefeng frankhefeng commented Jul 27, 2025

Issue # (if applicable)

Closes #35078.

Reason for this change

We want to use ACM exportable public certificates to replace all those certificates purchased from another vendor

Description of changes

Add certificateExportEnabled in acm.Certificate Construct

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit updated to cover new certificateExportEnabled property

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jul 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 27, 2025 14:03
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 27, 2025 14:05

Dismissing outdated PRLinter review.

@frankhefeng
Copy link
Contributor Author

version of package aws-cdk/aws-service-spec updated to get new L1 Construct with the new CertificateExport property of AWS::CertificateManager::Certificate

@frankhefeng frankhefeng changed the title feat(acm): Add support for ACM exportable public certificates feat(acm): add support for ACM exportable public certificates Jul 27, 2025
@frankhefeng
Copy link
Contributor Author

Exemption Request

This MR does not implement integration testing for the following reason:

To request an ACM exportable public certificate, a domain and a Route53 hosted zone are required. This is difficult in CI.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35079 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 1 review requesting changes and 1 approving review by reviewers with write access.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 28, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

… but received object "Runtime": { "Fn::FindInMap": [ ... ] },
@mergify mergify bot dismissed vishaalmehrishi’s stale review August 28, 2025 16:02

Pull request has been modified.

@mergify mergify bot dismissed vishaalmehrishi’s stale review September 1, 2025 02:29

Pull request has been modified.

@frankhefeng
Copy link
Contributor Author

hey @vishaalmehrishi , may I have some instruction what should I do for next step? Thanks

@vishaalmehrishi
Copy link
Contributor

hey @vishaalmehrishi , may I have some instruction what should I do for next step? Thanks

Hi @frankhefeng , yes, please take a look at this comment: #35079 (comment)

@frankhefeng
Copy link
Contributor Author

hey @vishaalmehrishi , may I have some instruction what should I do for next step? Thanks

Hi @frankhefeng , yes, please take a look at this comment: #35079 (comment)

Updated

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #35079 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 1 review requesting changes and 1 approving review by reviewers with write access.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@vishaalmehrishi
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@vishaalmehrishi vishaalmehrishi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 1, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 1, 2025 12:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c158e80 into aws:main Sep 1, 2025
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2025
@frankhefeng frankhefeng deleted the feat/acm-exportable-certificate branch September 1, 2025 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-certificatemanager): Support CertificateExport for acm.Certificate

5 participants