-
Couldn't load subscription status.
- Fork 4.3k
feat(acm): add support for ACM exportable public certificates #35079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(acm): add support for ACM exportable public certificates #35079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Dismissing outdated PRLinter review.
|
version of package |
Exemption RequestThis MR does not implement integration testing for the following reason: To request an ACM exportable public certificate, a domain and a Route53 hosted zone are required. This is difficult in CI. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #35079 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 1 review requesting changes and 1 approving review by reviewers with write access.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
… but received object "Runtime": { "Fn::FindInMap": [ ... ] },
Pull request has been modified.
packages/aws-cdk-lib/aws-certificatemanager/test/dns-validated-certificate.test.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
|
hey @vishaalmehrishi , may I have some instruction what should I do for next step? Thanks |
Hi @frankhefeng , yes, please take a look at this comment: #35079 (comment) |
Updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #35079 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 1 review requesting changes and 1 approving review by reviewers with write access.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35078.
Reason for this change
We want to use ACM exportable public certificates to replace all those certificates purchased from another vendor
Description of changes
Add
certificateExportEnabledinacm.CertificateConstructDescribe any new or updated permissions being added
N/A
Description of how you validated changes
Unit updated to cover new
certificateExportEnabledpropertyChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license