Skip to content

feat(sns): add notExistsCondition method #34712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 20, 2025
Merged

feat(sns): add notExistsCondition method #34712

merged 15 commits into from
Aug 20, 2025

Conversation

@jaw111
Copy link
Contributor

@jaw111 jaw111 commented Jun 13, 2025 •
edited
Loading

Issue # (if applicable)

Closes #34707

Reason for this change

Set subscription filter with exists false for a property.

Description of changes

Add new notExistsCondition() method.

Describe any new or updated permissions being added

None.

Description of how you validated changes

Extended existing integration test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jun 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 13, 2025 11:10
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 13, 2025
@jaw111 jaw111 marked this pull request as draft June 13, 2025 11:10
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@jaw111 jaw111 changed the title add existsCondition parameter on existsFilter method feat(aws-sns): add existsCondition parameter on existsFilter method Jun 13, 2025
@jaw111 jaw111 changed the title feat(aws-sns): add existsCondition parameter on existsFilter method feat(sns): add existsCondition parameter on existsFilter method Jun 13, 2025
@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch from cd6ddb2 to 4f4eafd Compare June 13, 2025 14:10
@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 14, 2025
@jaw111 jaw111 changed the title feat(sns): add existsCondition parameter on existsFilter method feat(sns): add notExistsCondition method Jun 18, 2025
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jun 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 18, 2025 20:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch from f5dfe11 to 3ab6c4b Compare June 18, 2025 20:42
@jaw111 jaw111 marked this pull request as ready for review June 18, 2025 21:00
@aws-cdk-automation aws-cdk-automation removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 19, 2025
jaw111
jaw111 commented Jun 19, 2025
View reviewed changes
packages/@aws-cdk-testing/framework-integ/test/aws-sns-subscriptions/test/integ.sns-sqs.ts Outdated
denylist: ['white', 'orange'],
})),
}),
price: sns.Filter.filter(sns.SubscriptionFilter.numericFilter({
Copy link
Contributor Author

@jaw111 jaw111 Jun 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification Request:

Does it make sense to specify multiple numeric filters that contradict each other? I assume the message has to match all filter rules to be sent to the SQS queue (logic is AND not OR), but the allowed values 100 and 200 will not satisfy the other numeric filters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the documentation, it appears the OR logic would apply. This means the filter would match any numeric value due to the greaterThan: 500 and lessThan: 1000 constraints.

So, it depends on what the intended purpose of such an integration test is. Should it just check the CloudFormation stack is built and deployed, or also test the behavior of the filter does what is expected and messages get filtered accordingly to subscribers?

@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch 4 times, most recently from e25ebe1 to b2d43cd Compare June 24, 2025 09:37
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 24, 2025
@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch 2 times, most recently from 0143a4c to 6c0eb9d Compare June 24, 2025 13:55
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Closed
@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch from 6c0eb9d to 9d15082 Compare July 1, 2025 10:51
@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch 2 times, most recently from 340468b to 115ca51 Compare July 11, 2025 12:30
@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch from 115ca51 to eeeac82 Compare July 15, 2025 08:14
@jaw111
Copy link
Contributor Author

jaw111 commented Jul 15, 2025

@pahud @badmintoncryer sorry to pester on this, but do you have any timeline when someone will be able to review this PR?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eeeac82
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaw111 jaw111 force-pushed the 34707-sns-subscription-filter-exists branch from eeeac82 to fc8840f Compare August 19, 2025 11:58
@vishaalmehrishi vishaalmehrishi self-assigned this Aug 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fd8677b into aws:main Aug 20, 2025
18 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vishaalmehrishi vishaalmehrishi vishaalmehrishi approved these changes

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees

@vishaalmehrishi vishaalmehrishi

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-sns-subscriptions: add support for not exists filter in a subscription filter

3 participants

@jaw111 @aws-cdk-automation @vishaalmehrishi